missing documentation for a few things

[cadeyrn]

Page URL

• https://firefox-admin-docs.mozilla.org/reference/policies/contentanalysis/
• https://firefox-admin-docs.mozilla.org/reference/policies/enabletrackingprotection/
• https://firefox-admin-docs.mozilla.org/reference/policies/extensionsettings/

What specific section or headline is this issue about?

No response

What did you expect to see?

While working on a new release of the Enterprise Policy Generator, I noticed that the documentation is missing the following items:

• ContentAnalysis: MaxConnectionsCount
• DisableRemoteImprovements
• EnableTrackingProtection: HarmfulAddon
• ExtensionSettings: allowed_types: sitepermission
• LocalNetworkAccess (already mentioned in Omitted policies #17)

Also, I wonder if the policies.json example for AllowUrlRegexList and DenyUrlRegexList in the ContentAnalysis policy is correct:

"AllowUrlRegexList": "https://example\.com/.* https://subdomain\.example\.com/.*"

Shouldn't the \ character be escaped in JSON?

"AllowUrlRegexList": "https://example\\.com/.* https://subdomain\\.example\\.com/.*"

Otherwise it shows as syntax error in my IDE.

Do you have anything more you want to share?

No response

[bsmth]

Hi @cadeyrn thanks a lot for reporting. These all look correct except for HarmfulAddon, which I don't see. Where did you spot this?

For AllowUrlRegexList - it might be worth checking with @mkaply

[cadeyrn]

These all look correct except for HarmfulAddon, which I don't see. Where did you spot this?

In the source code*:

https://searchfox.org/firefox-main/rev/85c939b2f940c94a429ba951e52a379ebcc5b0b5/browser/components/enterprisepolicies/Policies.sys.mjs#1325-1331

*) I always check source code changes for new polices so that I don't overlook anything for my extension.

[mkaply]

Thanks, I wasn't told about that one. I've asked the team for documentation on it.

[mkaply]

DisableRemoteImprovements is missing because it's new with this release. I was planning on documenting this week

[mkaply]

HarmfulAddon won't work. they implemented it incorrectly.

[cadeyrn]

• ContentAnalysis: MaxConnectionsCount => documented
• DisableRemoteImprovements => documented
• EnableTrackingProtection: HarmfulAddon => was removed, no longer needed
• ExtensionSettings: allowed_types: sitepermission => documented
• LocalNetworkAccess => PR already exists

That leaves just the question about the syntax in AllowUrlRegexList in the ContentAnalysis policy unanswered.

I have one another questions / suggestion: Based on https://hg-edge.mozilla.org/mozilla-central/rev/602e972901a4 and https://hg-edge.mozilla.org/mozilla-central/rev/34abfdeecba5, should the documentation of the PopupBlocking policy mention the part about third-party redirects? It's mentioned in the built-in documentation on about:polices.

[bsmth]

That leaves just the question about the syntax in AllowUrlRegexList in the ContentAnalysis policy unanswered.

I'll take a look at this shortly, thanks for raising.

I have one another questions / suggestion: Based on https://hg-edge.mozilla.org/mozilla-central/rev/602e972901a4 and https://hg-edge.mozilla.org/mozilla-central/rev/34abfdeecba5, should the documentation of the PopupBlocking policy mention the part about third-party redirects? It's mentioned in the built-in documentation on about:polices.

Yes, you're right, we should update the docs to reflect that:

• https://phabricator.services.mozilla.com/D254678