Skip to content

check-agent-record is RED on main: #995 is listed TWICE in .agents/issue-index.md, and the append-only rule forbids the obvious repair #1031

Description

@localai-bot

scripts/check-agent-record.py and tests/scripts/test_check_agent_record.py are RED on origin/main itself, so every branch cut from it inherits the failure in scripts/agent-preflight.sh:

ERROR: .agents/issue-index.md: issue #995 listed twice. Under `merge=union` a
duplicate is what two branches appending the same issue look like

Derived, not inferred

$ git show origin/main:.agents/issue-index.md | awk -F'|' '/^\| \[#/{print $2}' | sort | uniq -d
 [#995](https://github.com/mudler/vllm.cpp/issues/995)
$ git show origin/main:.agents/issue-index.md | grep -c '#995'
2

The uniq -d over all rows returns exactly one line, so #995 is the only duplicate and the count is 2, not an artifact of a partial match. Found on a branch that adds only #1005 and #1013; git diff origin/main -- .agents/issue-index.md on that branch shows both of its additions and neither #995 row.

How it happened, and why it is not a small clear fix

Both rows are legitimate under the append-only rule. The first filed #995. The second was appended by the change that closed it, restating the finding in the terms the fix established. Neither edited the other, which is exactly what the rule asks for — and check-agent-record.py forbids the result.

So this is a genuine contradiction between two rules in AGENTS.md § Every change starts from an issue, not a typo:

  • "The index is append-only. Add a row at the end. Never edit a row and never delete one, because GitHub holds the open and closed state and an edited row is duplicated rather than merged."
  • the checker: an issue listed twice is an error.

The obvious repair, deleting one of the two rows, is forbidden by the first rule and is the "make a red gate green by deleting an assertion" shape AGENTS.md § Changing the rules or a checker names. The checker's premise is also narrower than reality: it reads a duplicate as evidence of a union merge of two branches, and here it is evidence of one branch appending twice on purpose, months apart.

Not fixed in flow, and this is why. It needs a contract decision that the row filing it has no mandate to make: either the index gains a rule for "a second row about the same issue" (an explicit supersede marker the checker can read), or the checker stops treating a duplicate ID as an error and instead checks whatever the union-merge hazard actually is. Both change checker semantics and therefore need a spec, a red-before test and green-after evidence.

Owned by row ENG-EXPERT-STREAM, whose two commits appended both rows.

Not the same as #995

#995 was check-env-doc, is closed, and its fix landed in 45b022cdc. This is check-agent-record, and it was introduced by the bookkeeping of that fix rather than by its content.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions