Layer selection does not work

[hansu]

Hier nochmal als separates issue, damit es nicht untergeht, weil ich es relativ wichtig finde.

Im Tab "Ebenen" werden keine Ebenen im Dropdown menü angezeigt, egal welche DXF-Datei ich lade.
Bei den Objekten wird der dazugehörige Layer hingegen angezeigt...

[multigcs]

hmmm, bei mir funktioniert es, sowohl mit sem simple.dxf als auch dem all.dxf

vielleicht ein problem mit der ezdxf lib version !?!
ii python3-ezdxf 0.18.1-1

[hansu]

Hmm ich hab python3-ezdxf_0.14.2-3.

Ich bekomme auch immer

ERROR: parsing machine_cmd: list index out of range
error while drawing machine commands

Aber das kommt auch beim Öffnen einer STL-Datei.

[hansu]

Verhalten unverändert mit python3-ezdxf_0.18.1-1

[xplwowi]

The ezdxf library version is irrelevant here. The call to the self.lcombobjwidget combobox populating function in the load_drawings function is missing. For a change, the author did not forget about the widget that supports objects.
After loading the graphic, nothing updates the combobox.

For everything to work, you need to at least add there:

if self.lcombobjwidget is not None:
   self.lcombobjwidget_update()
   self.lcombobjwidget.setCurrentText(self.project["layer_active"])

[xplwowi]

By the way, great tool. The heavily patched dxf2gcode has just gone to the corner. To be completely happy with my simple workflows, I only lack the option of retracting the tool after the object's machining phase at a given depth is finished, to have working "peck drilling" on DXF objects of the "point" type. This is a loose comment. When I notice that the author has started committing again (I hope he doesn't abandon the project) I will file an enhancement request to add the extra "drilling" functionality.

[hansu]

When I notice that the author has started committing again (I hope he doesn't abandon the project) I will file an enhancement request to add the extra "drilling" functionality.

If not, you could also start to further develop a fork, but sure this is not the preferred option...

[xplwowi]

Hehe, not only am I too stupid for this, but unfortunately I also don't have a single moment of free time.

[xplwowi]

There is another necessary fix for this bug report.

In order for the input field for the "Step" value to work correctly, the conditional block

if setup_data["mill"]["step"] >= 0.0:
   setup_data["mill"]["step"] = -0.05

in the layer_changed() function should be moved before the loop:

for obj in self.project["objects"].values():
   ...

Currently it is after the loop and this causes the 0.0 step to be set incorrectly on DXF objects and it is impossible to correct it later.

[multigcs]

There is another necessary fix for this bug report.

In order for the input field for the "Step" value to work correctly, the conditional block

if setup_data["mill"]["step"] >= 0.0:
   setup_data["mill"]["step"] = -0.05

in the layer_changed() function should be moved before the loop:

for obj in self.project["objects"].values():
   ...

Currently it is after the loop and this causes the 0.0 step to be set incorrectly on DXF objects and it is impossible to correct it later.

aa4a4ed

thanks

[xplwowi]

@multigcs please also look at what I wrote here: #35 (comment)

Without this modification, layer selection combobox is always empty. This is the main part of the solution to the bug this thread is about.

[multigcs]

viaconstructor.py line: 3745 ???

        if self.lcombobjwidget is not None:
            self.lcombobjwidget_update()
            if self.project["layersetup"]:
                self.project["layer_active"] = "(".join(list(self.project["layersetup"])[0].split("(")[0:-1]).strip()
                self.lcombobjwidget.setCurrentText(self.project["layer_active"])

there is already an 'setCurrentText'

can not reproduce this bug :(

[multigcs]

ahh, ok, sorry, can reproduce it if i open the file via menu, not as cmd argument

the problem is, that 'layersetup' is not filled in the project dict

[xplwowi]

No, it's not the init() function, it's the load_drawings() function. I can't figure out how (assuming we're working on the same code base) we have different results. Maybe you're using command-line graphics loading instead of GUI functions? The load_drawings() function doesn't update the self.lcombobjwidget widget, but it does update the self.combobjwidget widget, and that's why it's the only one that works correctly.

Edit: you were faster :)