Skip to content

Critical: “atomic commit” is not atomic and can silently drop data #29

@congwang-mk

Description

@congwang-mk

Commit deletes tombstoned base paths first, then copies delta files one by one, while ignoring create_dir_all and copy_entry errors at branch.rs (line 637) and branch.rs (line 707). After that it removes the branch directory. A failed copy can still be reported as success and destroy the only delta copy. This directly contradicts the atomic commit claim in README.md (line 12).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions