From ceda7a5061afbe69daf9223b7c2bb9da7889a2e7 Mon Sep 17 00:00:00 2001 From: Qoole <2862661+qoole@users.noreply.github.com> Date: Thu, 7 May 2026 18:48:05 +0100 Subject: [PATCH] perf(logging): reduce logging overhead in hot paths - Remove dead debug lambda in PUTFileJob::start() that constructed a temporary QLoggingCategory on every upload progress tick. The signal is already connected to the proper handler on the next line. - Add QtInfoMsg default to 3 Q_LOGGING_CATEGORY declarations that were missing it, preventing debug-level output from being active by default. - Remove tr() and QString::number() allocations from a qCDebug call in usermodel.cpp quota update path. Signed-off-by: Qoole <2862661+qoole@users.noreply.github.com> --- src/gui/tray/usermodel.cpp | 2 +- src/libsync/basepropagateremotedeleteencrypted.cpp | 2 +- src/libsync/propagateremotedeleteencrypted.cpp | 2 +- src/libsync/propagateremotedeleteencryptedrootfolder.cpp | 2 +- src/libsync/propagateupload.cpp | 4 ---- 5 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gui/tray/usermodel.cpp b/src/gui/tray/usermodel.cpp index 96144b83f9653..99b206c6dc934 100644 --- a/src/gui/tray/usermodel.cpp +++ b/src/gui/tray/usermodel.cpp @@ -1823,7 +1823,7 @@ void User::slotQuotaChanged(const int64_t &usedBytes, const int64_t &availableBy const auto percent = (double)usedBytes / (double)total * 100.0; const auto percentInt = qMin(qRound(percent), 100); - qCDebug(lcActivity) << tr("Quota is updated; %1 percent of the total space is used.").arg(QString::number(percentInt)); + qCDebug(lcActivity) << "Quota updated:" << percentInt << "% used"; int thresholdPassed = 0; if (_lastQuotaPercent < 80 && percentInt >= 80) { diff --git a/src/libsync/basepropagateremotedeleteencrypted.cpp b/src/libsync/basepropagateremotedeleteencrypted.cpp index 7d5984780794b..718003bbb8fd8 100644 --- a/src/libsync/basepropagateremotedeleteencrypted.cpp +++ b/src/libsync/basepropagateremotedeleteencrypted.cpp @@ -12,7 +12,7 @@ #include "deletejob.h" #include "owncloudpropagator.h" -Q_LOGGING_CATEGORY(ABSTRACT_PROPAGATE_REMOVE_ENCRYPTED, "nextcloud.sync.propagator.remove.encrypted") +Q_LOGGING_CATEGORY(ABSTRACT_PROPAGATE_REMOVE_ENCRYPTED, "nextcloud.sync.propagator.remove.encrypted", QtInfoMsg) namespace OCC { diff --git a/src/libsync/propagateremotedeleteencrypted.cpp b/src/libsync/propagateremotedeleteencrypted.cpp index 8f1df9ff9d353..74c6f14734bb8 100644 --- a/src/libsync/propagateremotedeleteencrypted.cpp +++ b/src/libsync/propagateremotedeleteencrypted.cpp @@ -13,7 +13,7 @@ using namespace OCC; -Q_LOGGING_CATEGORY(PROPAGATE_REMOVE_ENCRYPTED, "nextcloud.sync.propagator.remove.encrypted") +Q_LOGGING_CATEGORY(PROPAGATE_REMOVE_ENCRYPTED, "nextcloud.sync.propagator.remove.encrypted", QtInfoMsg) PropagateRemoteDeleteEncrypted::PropagateRemoteDeleteEncrypted(OwncloudPropagator *propagator, SyncFileItemPtr item, QObject *parent) : BasePropagateRemoteDeleteEncrypted(propagator, item, parent) diff --git a/src/libsync/propagateremotedeleteencryptedrootfolder.cpp b/src/libsync/propagateremotedeleteencryptedrootfolder.cpp index 24fa79275089a..e934400cf85ed 100644 --- a/src/libsync/propagateremotedeleteencryptedrootfolder.cpp +++ b/src/libsync/propagateremotedeleteencryptedrootfolder.cpp @@ -31,7 +31,7 @@ namespace { using namespace OCC; -Q_LOGGING_CATEGORY(PROPAGATE_REMOVE_ENCRYPTED_ROOTFOLDER, "nextcloud.sync.propagator.remove.encrypted.rootfolder") +Q_LOGGING_CATEGORY(PROPAGATE_REMOVE_ENCRYPTED_ROOTFOLDER, "nextcloud.sync.propagator.remove.encrypted.rootfolder", QtInfoMsg) PropagateRemoteDeleteEncryptedRootFolder::PropagateRemoteDeleteEncryptedRootFolder(OwncloudPropagator *propagator, SyncFileItemPtr item, QObject *parent) : BasePropagateRemoteDeleteEncrypted(propagator, item, parent) diff --git a/src/libsync/propagateupload.cpp b/src/libsync/propagateupload.cpp index 5011eb1084fe5..04f29c8eeaa1d 100644 --- a/src/libsync/propagateupload.cpp +++ b/src/libsync/propagateupload.cpp @@ -71,10 +71,6 @@ void PUTFileJob::start() qCWarning(lcPutJob) << " Network error: " << reply()->errorString(); } - connect(reply(), &QNetworkReply::uploadProgress, this, [requestID] (qint64 bytesSent, qint64 bytesTotal) { - qCDebug(lcPutJob()) << requestID << "upload progress" << bytesSent << bytesTotal; - }); - connect(reply(), &QNetworkReply::uploadProgress, this, &PUTFileJob::uploadProgress); connect(this, &AbstractNetworkJob::networkActivity, account().data(), &Account::propagatorNetworkActivity);