From 706897046655a43e10acf09ac64c3b935fd24111 Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Mon, 22 Jun 2026 23:11:34 +0200 Subject: [PATCH 1/2] chore(comments): resolve ESLint warnings Signed-off-by: Ferdinand Thiessen --- .../{Comment.vue => CommentEntry.vue} | 3 +-- apps/comments/src/services/DavClient.ts | 23 ++----------------- apps/comments/src/services/GetComments.ts | 4 ++-- .../src/views/ActivityCommentAction.vue | 6 ++--- .../src/views/ActivityCommentEntry.vue | 6 ++--- apps/comments/src/views/CommentsApp.vue | 8 +++---- 6 files changed, 15 insertions(+), 35 deletions(-) rename apps/comments/src/components/{Comment.vue => CommentEntry.vue} (99%) diff --git a/apps/comments/src/components/Comment.vue b/apps/comments/src/components/CommentEntry.vue similarity index 99% rename from apps/comments/src/components/Comment.vue rename to apps/comments/src/components/CommentEntry.vue index 5f04977bdea16..0b2fd8fea3e96 100644 --- a/apps/comments/src/components/Comment.vue +++ b/apps/comments/src/components/CommentEntry.vue @@ -134,8 +134,7 @@ const NcRichContenteditable = defineAsyncComponent(() => import('@nextcloud/vue/ const NcRichText = defineAsyncComponent(() => import('@nextcloud/vue/components/NcRichText')) export default { - /* eslint vue/multi-word-component-names: "warn" */ - name: 'Comment', + name: 'CommentEntry', components: { IconArrowRight, diff --git a/apps/comments/src/services/DavClient.ts b/apps/comments/src/services/DavClient.ts index b1832b0f715ab..8aab715c21d18 100644 --- a/apps/comments/src/services/DavClient.ts +++ b/apps/comments/src/services/DavClient.ts @@ -3,28 +3,9 @@ * SPDX-License-Identifier: AGPL-3.0-or-later */ -import { getRequestToken, onRequestTokenUpdate } from '@nextcloud/auth' -import { createClient } from 'webdav' +import { getClient } from '@nextcloud/files/dav' import { getRootPath } from '../utils/davUtils.ts' -// init webdav client -const client = createClient(getRootPath()) - -// set CSRF token header -/** - * @param token - */ -function setHeaders(token) { - client.setHeaders({ - // Add this so the server knows it is an request from the browser - 'X-Requested-With': 'XMLHttpRequest', - // Inject user auth - requesttoken: token ?? '', - }) -} - -// refresh headers when request token changes -onRequestTokenUpdate(setHeaders) -setHeaders(getRequestToken()) +const client = getClient(getRootPath()) export default client diff --git a/apps/comments/src/services/GetComments.ts b/apps/comments/src/services/GetComments.ts index 884b66b77d25c..409bacef0c87e 100644 --- a/apps/comments/src/services/GetComments.ts +++ b/apps/comments/src/services/GetComments.ts @@ -52,8 +52,8 @@ export async function getComments({ resourceType, resourceId }, options: { offse /** * https://github.com/perry-mitchell/webdav-client/blob/8d9694613c978ce7404e26a401c39a41f125f87f/source/operations/directoryContents.ts * - * @param result - * @param isDetailed + * @param result - the DAV response result + * @param isDetailed - whether to return detailed file information */ function getDirectoryFiles( result: DAVResult, diff --git a/apps/comments/src/views/ActivityCommentAction.vue b/apps/comments/src/views/ActivityCommentAction.vue index 376c8ae0888ed..03626f6dd9262 100644 --- a/apps/comments/src/views/ActivityCommentAction.vue +++ b/apps/comments/src/views/ActivityCommentAction.vue @@ -4,7 +4,7 @@ -->