codebase-memory-cli/.github/workflows/_lint.yml at main · ngallodev/codebase-memory-cli · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
# Reusable: lint only (cppcheck + clang-format).
# Security-static and CodeQL gate are separate — see _security.yml.
name: Lint & Security

on:
  workflow_call:
    inputs:
      lanes:
        description: 'PR lane selection (scripts/ci/select-lanes.sh JSON list); "all" = every job (dry run, release)'
        type: string
        default: all

permissions:
  contents: read

jobs:
  lint:
    if: ${{ inputs.lanes == 'all' || contains(fromJSON(inputs.lanes), 'lint') }}
    # Pinned, not ubuntu-latest: the LLVM install below adds an
    # apt.llvm.org llvm-toolchain-NOBLE repo, which is 24.04 by name. When
    # GitHub moves ubuntu-latest to the next LTS this job breaks on a day
    # nobody chose. Pin the runner to the release the repo line already names.
    runs-on: ubuntu-24.04
    # 15 min proved too tight on a slow runner day and a timed-out lint reads
    # as "cancelled", which the release graph must treat as a hard stop; keep
    # a bound, but one only a genuine hang can hit. 30 min stopped being that
    # in 2026-10: single-process cppcheck over a src tree that grew ~60 % in
    # files took the lint step from ~8 to 22-29 min, and three runs on
    # 2026-10-13 were cancelled at 30 min with cppcheck still alive.
    timeout-minutes: 45
    steps:
      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

      # Tests must pass or fail — no SKIPs except genuinely platform-specific
      # ones (SKIP_PLATFORM / #ifdef). Fails the lint phase on any plain SKIP().
      - name: No-skips policy (tests pass or fail)
        run: bash scripts/check-no-test-skips.sh

      - name: Install build deps
        run: sudo apt-get update && sudo apt-get install -y zlib1g-dev cmake

      - name: Install LLVM 20
        run: |
          wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
          echo "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-20 main" | sudo tee /etc/apt/sources.list.d/llvm-20.list
          sudo apt-get update
          sudo apt-get install -y clang-format-20

      - uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
        id: cppcheck-cache
        with:
          path: /opt/cppcheck
          key: cppcheck-2.20.0-ubuntu-amd64

      - name: Build cppcheck 2.20.0
        if: steps.cppcheck-cache.outputs.cache-hit != 'true'
        run: |
          git clone --depth 1 --branch 2.20.0 https://github.com/danmar/cppcheck.git /tmp/cppcheck
          cmake -S /tmp/cppcheck -B /tmp/cppcheck/build -DCMAKE_BUILD_TYPE=Release -DHAVE_RULES=OFF -DCMAKE_INSTALL_PREFIX=/opt/cppcheck
          cmake --build /tmp/cppcheck/build -j$(nproc)
          cmake --install /tmp/cppcheck/build

      - name: Add cppcheck to PATH
        run: echo "/opt/cppcheck/bin" >> "$GITHUB_PATH"

      - name: Lint (cppcheck + clang-format, no clang-tidy — enforced locally)
        run: scripts/lint.sh --ci CLANG_FORMAT=clang-format-20

  # Memory-analyzer gate (user decision 2026-08-03: runner cost accepted).
  # Path-sensitive clang-analyzer over the memory checks only: leak paths,
  # null derefs, uninitialized reads. Its first run produced 9 real fixes;
  # the gate is green because every false positive was RESTRUCTURED for
  # provability (never suppressed — the NOLINT ban applies here too).
  # Vendored-tree diagnostics are path-filtered, mirroring .cppcheck.
  lint-mem:
    if: ${{ inputs.lanes == 'all' || contains(fromJSON(inputs.lanes), 'lint-mem') }}
    # Pinned for the same reason as `lint`: llvm-toolchain-noble-21 below.
    runs-on: ubuntu-24.04
    timeout-minutes: 60
    steps:
      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

      - name: Install build deps
        run: sudo apt-get update && sudo apt-get install -y zlib1g-dev

      - name: Install LLVM 21 (pinned analyzer toolchain)
        run: |
          wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
          echo "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-21 main" | sudo tee /etc/apt/sources.list.d/llvm-21.list
          sudo apt-get update
          sudo apt-get install -y clang-tidy-21

      - name: Memory-analyzer gate
        run: scripts/ci/lint-mem.sh clang-tidy-21