Skip to content

Commit 2433860

Browse files
authored
Fix provisioning logs (#4428)
Add error level log for invalid config so it doesn't get lost in the debug layer.
1 parent 3676f99 commit 2433860

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

internal/controller/provisioner/provisioner.go

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -255,13 +255,22 @@ func (p *NginxProvisioner) provisionNginx(
255255
func(ctx context.Context) (bool, error) {
256256
res, upsertErr = controllerutil.CreateOrUpdate(ctx, p.k8sClient, obj, objectSpecSetter(obj))
257257
if upsertErr != nil {
258-
p.cfg.Logger.V(1).Info(
259-
"Retrying CreateOrUpdate for nginx resource after error",
260-
"namespace", gateway.GetNamespace(),
261-
"name", resourceName,
262-
"error", upsertErr.Error(),
263-
)
264-
return false, nil //nolint:nilerr // continue retrying
258+
if apierrors.IsInvalid(upsertErr) { // log this error at the error level
259+
p.cfg.Logger.Error(
260+
upsertErr,
261+
"Retrying CreateOrUpdate for nginx resource after error",
262+
"namespace", gateway.GetNamespace(),
263+
"name", resourceName,
264+
)
265+
} else {
266+
p.cfg.Logger.V(1).Info(
267+
"Retrying CreateOrUpdate for nginx resource after error",
268+
"namespace", gateway.GetNamespace(),
269+
"name", resourceName,
270+
"error", upsertErr.Error(),
271+
)
272+
}
273+
return false, nil
265274
}
266275
return true, nil
267276
},

0 commit comments

Comments
 (0)