Fix fingerprint stacking on incremental builds (#11)#12
Merged
sn merged 1 commit intoApr 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the asset fingerprinting logic in the bundler to prevent files from being re-fingerprinted across multiple builds, addressing an issue where hashes could be stacked on filenames. It also adds new tests to ensure this behavior and moves the
html5libdependency from the development group to required dependencies.Asset fingerprinting improvements:
Bundler.fingerprint_assetsmethod to skip files that are already fingerprinted (i.e., filenames ending with an 8-character hex hash), preventing double hashing on incremental builds. [1] [2]_FINGERPRINT_REto reliably detect already fingerprinted files by their naming pattern.Testing enhancements:
tests/test_bundler.pyto verify that already fingerprinted files are skipped and that incremental builds do not stack hashes or create duplicate fingerprinted files.Dependency management:
html5libfrom thedevoptional dependencies to the main dependencies inpyproject.toml, making it a required package for the project.1.0.12to1.0.13inpyproject.toml.