Skip to content

V4 activity stream keys param, seems to be handled incorrectly? #201

@alexd-femmi

Description

@alexd-femmi

I have just upgraded to v4 of node-strava-v3, from v2. I changed my stream query params from types to keys, which is types as an array of strings.

However I was only getting distance returned no matter what I did.

Looking at this line here, in how queries are stringified, it looks like querystring would be converting them to something like key=X&key=Y, instead of what the API expects, which is a comma separated string list of keys.

When I changed to a comma separated string list, it worked as expected.

So I think either the typings need to be changed, or the query handler should account for this.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions