fixup! buffer: align Blob and File with Web IDL

Keep rejecting bare SharedArrayBuffer for browser compatibility.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex

Author: panva

lib/internal/blob.js

@@ -51,6 +51,7 @@ const {
 } = require('internal/worker/js_transferable');
 
 const {
+  isAnyArrayBuffer,
   isArrayBuffer,
   isArrayBufferView,
   isDataView,
@@ -155,7 +156,9 @@ const blobPartsConverter = createSequenceConverter((source, opts = kEmptyObject)
   if (isBlob(source)) {
     return source;
   }
-  if (isArrayBuffer(source) || isArrayBufferView(source)) {
+  // Match browsers for bare SharedArrayBuffer pending a resolution of
+  // https://github.com/whatwg/webidl/issues/1491.
+  if (isAnyArrayBuffer(source) || isArrayBufferView(source)) {
     return converters.BufferSource(source, opts);
   }
   return converters.USVString(source, opts);

test/parallel/test-blob-file-webidl.js

@@ -89,15 +89,16 @@ const { Blob, File } = require('node:buffer');
       assert.strictEqual(await copied.text(), part === buffer ? 'ABCD' : 'BC');
     }
 
-    // A bare SharedArrayBuffer falls through to the USVString union member;
-    // views backed by shared memory still select BufferSource and throw.
-    assert.strictEqual(await create([new SharedArrayBuffer(4)]).text(),
-                       '[object SharedArrayBuffer]');
-    for (const view of [
+    // Reject both bare shared buffers and views for browser compatibility.
+    for (const part of [
+      new SharedArrayBuffer(4),
       new Uint8Array(new SharedArrayBuffer(4)),
       new DataView(new SharedArrayBuffer(4)),
     ]) {
-      assert.throws(() => create([view]), TypeError);
+      assert.throws(() => create([part]), {
+        name: 'TypeError',
+        code: 'ERR_INVALID_ARG_TYPE',
+      });
     }
     for (const part of [
       new ArrayBuffer(4, { maxByteLength: 8 }),