fs: fix incorrect dereferencing of src arg in cpSync #60945
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
anonrig
approved these changes
Dec 3, 2025
dario-piotrowicz
approved these changes
Dec 3, 2025
github-actions
bot
removed
the
request-ci
Collaborator
npaun
force-pushed
the
npaun/fix-cpsync-dereference-true
branch
from
49bc013 to
4c47117
Compare
juanarbol
approved these changes
Dec 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60945 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 703 703
Lines 208406 208406
Branches 40198 40193 -5
=======================================
+ Hits 184502 184504 +2
- Misses 15901 15908 +7
+ Partials 8003 7994 -9
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Dec 4, 2025
marco-ippolito
approved these changes
Dec 5, 2025
Comment on lines
+5
to
+6
| // In this test, both the cp and cpSync functions are attempting to copy | ||
| // a file over a symlinked directory. |
Member
There was a problem hiding this comment.
Unlike the original test-fs-cp-sync-dereference.js, this one seems to test only the synchronous version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59168
As for the destination parameter symlink_status and status were accidentally swapped. symlink_status does NOT dereference while status does.