Created working helm config

[kiat-huang]

so DNS/SSL works via Makefile as the other services: DDS, Converter. Makefile points to Prod

[suokko]

git pull and git merge shouldn't be used with a local working branch. It complicates history with potential to include same commit multiple times. I use git pull extremely rarely for this reason.

git rebase origin/master would move old changes on top of the latest changes. I think we need to have a voice call helping with git rebase.

Your merge broke compilation by moving server code to a subdirectory. It also deleted the ww-deal submodule which is required for build to work.

[tameware]

May I leave this to @suokko? I think he's substantially better qualified to review this pull than I am.

[kiat-huang]

May I leave this to @suokko? I think he's substantially better qualified to review this pull than I am.

Totally fine, he's helping me resolve this over discord and also suggesting improvements

[kiat-huang]

I think that's all changes made and the "uninstall check" implemented.

[suokko]

A couple small simplification ideas. Removing three lines would make it good to me.

After this is merged I will rebasemy build improvements on top these changes.

[suokko]

The uninstall target is implicitly phony because it doesn't create anything with the path. Phony targets tell make to run the target everyone even if output is newer than dependencies.

[suokko]

I don't think this version benefits from the ask delete variable. The example had idea to allow make uninstall ASK_DELETE=1 to skip the prompt. But it won't work with this variant.

[suokko]

There is a commit message formatting issue. The second commit has longer than allowed short description. You can see the formatting issue at 571867a

To avoid the formatting issue first line in commit message should be a short to the point. Then following paragraphs can be as long as developer wishes to ramble about changes. I have seen commit messages with about 20 lines for a code line change.

It is good idea to use set textwidth=72. I get that configuration from vim-polyglot plugin. The plugin provide many other improvements over vim defaults.

[kiat-huang]

There is a commit message formatting issue. The second commit has longer than allowed short description. You can see the formatting issue at 571867a

To avoid the formatting issue first line in commit message should be a short to the point. Then following paragraphs can be as long as developer wishes to ramble about changes. I have seen commit messages with about 20 lines for a code line change.

It is good idea to use set textwidth=72. I get that configuration from vim-polyglot plugin. The plugin provide many other improvements over vim defaults.

Ack, trying it.

[suokko]

@kiat-huang , I modified your uninstall changes a bit.

What do you think about the changes?