Skip to content

Conversation

@quanbisen
Copy link

I used Cursor to fix a bug in the gRPC client call that occasionally triggered panics. After the fix, it has been running stably for 3 days without any issues. Before the fix, the program would panic within a day. While this fix resolved the gRPC panic issue, I'm unsure if the changes might affect other functionalities – though my current tests show no problems.

@quanbisen quanbisen requested a review from a team as a code owner October 30, 2025 05:02
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 30, 2025

CLA Not Signed

Copy link
Contributor

@RonFed RonFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the rationale for this fix. It seems like this changes some local variables to be stored on storage maps but these maps are accessed within the same function - so I'm not sure how that helps.

@quanbisen
Copy link
Author

I'm not sure I understand the rationale for this fix. It seems like this changes some local variables to be stored on storage maps but these maps are accessed within the same function - so I'm not sure how that helps.

but it work for me now, I'm sure it fix grpc call panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants