Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
---
"""

from collections import deque
from collections.abc import Iterable, Sequence
from itertools import chain
from json import dumps
Expand Down Expand Up @@ -172,14 +171,14 @@ class _CustomCollector:

def __init__(self, disable_target_info: bool = False, prefix: str = ""):
self._callback = None
self._metrics_datas: deque[MetricsData] = deque()
self._metrics_data: MetricsData | None = None
self._disable_target_info = disable_target_info
self._target_info = None
self._prefix = prefix

def add_metrics_data(self, metrics_data: MetricsData) -> None:
"""Add metrics to Prometheus data"""
self._metrics_datas.append(metrics_data)
self._metrics_data = metrics_data

def collect(self) -> Iterable[PrometheusMetric]:
"""Collect fetches the metrics from OpenTelemetry
Expand All @@ -190,29 +189,29 @@ def collect(self) -> Iterable[PrometheusMetric]:
if self._callback is not None:
self._callback()

metrics_data = self._metrics_data
self._metrics_data = None

if metrics_data is None:
return

metric_family_id_metric_family = {}

if len(self._metrics_datas):
if not self._disable_target_info:
if self._target_info is None:
attributes: Attributes = {}
for res in self._metrics_datas[0].resource_metrics:
attributes = {**attributes, **res.resource.attributes}
if not self._disable_target_info:
if self._target_info is None:
attributes: Attributes = {}
for res in metrics_data.resource_metrics:
attributes = {**attributes, **res.resource.attributes}

self._target_info = self._create_info_metric(
_TARGET_INFO_NAME, _TARGET_INFO_DESCRIPTION, attributes
)
metric_family_id_metric_family[_TARGET_INFO_NAME] = (
self._target_info
self._target_info = self._create_info_metric(
_TARGET_INFO_NAME, _TARGET_INFO_DESCRIPTION, attributes
)
metric_family_id_metric_family[_TARGET_INFO_NAME] = self._target_info

while self._metrics_datas:
self._translate_to_prometheus(
self._metrics_datas.popleft(), metric_family_id_metric_family
)
self._translate_to_prometheus(metrics_data, metric_family_id_metric_family)

if metric_family_id_metric_family:
yield from metric_family_id_metric_family.values()
if metric_family_id_metric_family:
yield from metric_family_id_metric_family.values()

# pylint: disable=too-many-locals,too-many-branches
def _translate_to_prometheus(
Expand Down
7 changes: 7 additions & 0 deletions shim/opentelemetry-opencensus-shim/tests/test_patch.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import unittest

from opencensus.trace import execution_context
from opencensus.trace.tracer import Tracer
from opencensus.trace.tracers.noop_tracer import NoopTracer

Expand All @@ -13,9 +14,15 @@
class TestPatch(unittest.TestCase):
def setUp(self):
uninstall_shim()
# Clear any OpenCensus execution context (current span / tracer) that
# may have been left by a previous test, e.g. test_shim_with_sdk.py.
# Without this, Tracer() can pick up a stale ContextTracer from the
# thread-local store and fail the assertIsInstance(…, NoopTracer) checks.
execution_context.clean()

def tearDown(self):
uninstall_shim()
execution_context.clean()

def test_install_shim(self):
# Initially the shim is not installed. The Tracer class has no tracer property, it is
Expand Down
Loading