Skip to content

Fix broken detection of completed OLSConfig #36

@lpiwowar

Description

@lpiwowar

Description

If you deploy OpenStack Lightspeed and check the instance status section, you'll see this:

...
status:
  conditions:
   - lastTransitionTime: "2025-11-14T09:25:31Z"
     message: Setup started
     reason: Init
     status: Unknown
     type: Ready
   - lastTransitionTime: "2025-11-14T09:21:58Z"
     message: OpenStack Lightspeed not started
     reason: Init
     status: Unknown
     type: OpenStackLightspeedReady   

even when the OLS is fully deployed, and I can chat with OpenStack Lightspeed through the chatbot in the console. It looks like the status section on the OLSConfig is not fully updated as well:

...
status:
  conditions:
    - lastTransitionTime: "2025-11-14T09:22:29Z"
      message: All components are successfully deployed
      reason: Reconciling
      status: "True"
      type: ConsolePluginReady
    - lastTransitionTime: "2025-11-14T09:22:29Z"
      message: All components are successfully deployed
      reason: Reconciling
      status: "True"
      type: CacheReady
    - lastTransitionTime: "2025-11-14T09:22:01Z"
      message: In Progress
      reason: Reconciling
      status: "False"
      type: ApiReady  

But I think this might be caused by us. Because I can imagine we keep patching here the OLSConfig even when nothing changed (not 100 % sure about this) [1].

[1]

_, err = controllerutil.CreateOrPatch(ctx, r.Client, &olsConfig, func() error {

Expected behavior

All the conditions are True in the status section when the OpenStack Lightspeed is fully deployed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions