Skip to content

Commit ee39a15

Browse files
Fix compatibility with urllib3 v2.6
urllib3 v2.6 removed `HTTPResponse.getheader(name, default)` in favor of `HTTPResponse.headers.get(name, default)`, see urllib3/urllib3#3622 Changed from `resp.raw.getheader` to `resp.headers.get` for compatibility. Fixed `test_response_headers` test to verify getheader() works properly. Change-Id: Ic0fab4ca6407f5435d87aa02d533f3eb826f5b3b Signed-off-by: Anthony Roussel <anthony@roussel.dev>
1 parent 0c73602 commit ee39a15

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

swiftclient/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ def putrequest(self, full_path, data=None, headers=None, files=None):
441441
def getresponse(self):
442442
"""Adapt requests response to httplib interface"""
443443
self.resp.status = self.resp.status_code
444-
old_getheader = self.resp.raw.getheader
444+
old_getheader = self.resp.headers.get
445445

446446
def _decode_header(string):
447447
if string is None:

test/unit/test_swiftclient.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2003,6 +2003,7 @@ def test_response_headers(self):
20032003
self.assertEqual(
20042004
'\u062a-value', resp.getheader('\u062a-UNICODE'))
20052005
self.assertEqual('', resp.getheader('empty-header'))
2006+
self.assertEqual('"%s"' % EMPTY_ETAG, resp.getheader('etag'))
20062007
self.assertEqual(
20072008
dict([('\u062a-unicode', '\u062a-value'),
20082009
('empty-header', ''),

0 commit comments

Comments
 (0)