Skip to content

fix(login): remove model-data endpoint from SSO interceptor#303

Merged
chilingling merged 1 commit into
opentiny:developfrom
hexqi:fix/model-sso
Apr 25, 2026
Merged

fix(login): remove model-data endpoint from SSO interceptor#303
chilingling merged 1 commit into
opentiny:developfrom
hexqi:fix/model-sso

Conversation

@hexqi
Copy link
Copy Markdown
Collaborator

@hexqi hexqi commented Apr 25, 2026

Summary

临时移除model-data API鉴权例外,规避风险。

  • Remove /platform-center/api/model-data/** from the SSO interceptor whitelist to enforce authentication on model-data endpoints

Summary by CodeRabbit

  • Chores
    • Authentication interception updated so additional platform API endpoints are now validated through the SSO authentication flow, ensuring those requests are processed by the central SSO check.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b7f60e8c-d04e-41e2-a7f8-b8c393a123ad

📥 Commits

Reviewing files that changed from the base of the PR and between ab1f7bf and e53053b.

📒 Files selected for processing (1)
  • base/src/main/java/com/tinyengine/it/login/config/LoginConfig.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • base/src/main/java/com/tinyengine/it/login/config/LoginConfig.java

Walkthrough

Removed an exclusion pattern from the interceptor configuration in LoginConfig.java. Requests to /platform-center/api/model-data/** will now be intercepted by ssoInterceptor under the catch-all "/**" rule instead of being excluded.

Changes

Cohort / File(s) Summary
Interceptor Configuration
base/src/main/java/com/tinyengine/it/login/config/LoginConfig.java
Removed exclusion for /platform-center/api/model-data/** in addInterceptors, so requests matching that pattern are now processed by ssoInterceptor under the existing "/**" mapping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

I hopped the config, trimmed a trailing line,
Now model-data strolls beneath the sign,
The guard inspects where silence lay—
A rabbit cheers for rules at play! 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(login): remove model-data endpoint from SSO interceptor' directly and clearly summarizes the main change: removing a path from the SSO interceptor exclusion list.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chilingling chilingling merged commit d02daa9 into opentiny:develop Apr 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants