Fix c_void_p for large and negative values.

This fixes mesonbuild arch detection on Windows, where they do

kernel32 = ctypes.windll.kernel32
process = ctypes.c_void_p(kernel32.GetCurrentProcess())

GetCurrentProcess() is documented to return -1, and we refused to convert a
negative value to a pointer.

Author: timfel

graalpython/com.oracle.graal.python.test/src/tests/cpyext/test_ctypes.py

@@ -39,6 +39,7 @@
 import ctypes
 import os.path
 import struct
+import sys
 
 from tests.cpyext import CPyExtTestCase, CPyExtType
 
@@ -225,3 +226,27 @@ class MyLargeStruct(ctypes.Structure):
             assert result.num7 == 42
         finally:
             os.chdir(original_cwd)
+
+
+def test_void_p():
+    assert ctypes.c_void_p(True).value == ctypes.c_void_p(1).value
+    assert ctypes.c_void_p(False).value == ctypes.c_void_p(0).value
+    assert ctypes.c_void_p(2**128 - 1).value == ctypes.c_void_p(2**64 - 1).value
+    try:
+        ctypes.c_void_p(2**128 - 1)
+    except TypeError as e:
+        assert "cannot be converted to pointer" in str(e)
+
+
+def test_meson_windows_detect_native_arch() -> str:
+    if sys.platform != 'win32':
+        return
+    process_arch = ctypes.c_ushort()
+    native_arch = ctypes.c_ushort()
+    kernel32 = ctypes.windll.kernel32
+    process = ctypes.c_void_p(kernel32.GetCurrentProcess())
+    try:
+        if kernel32.IsWow64Process2(process, ctypes.byref(process_arch), ctypes.byref(native_arch)):
+            assert native_arch.value == 0x8664, "only amd64 supported by GraalPy on Windows"
+    except AttributeError as e:
+        assert "Unknown identifier: IsWow64Process2" in str(e)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ctypes/CFieldBuiltins.java

@@ -725,19 +725,14 @@ static Object Z_set(@SuppressWarnings("unused") FieldSet setfunc, Pointer ptr, O
         @Specialization(guards = "setfunc == P_set")
         static Object P_set(@SuppressWarnings("unused") FieldSet setfunc, Pointer ptr, Object value, @SuppressWarnings("unused") int size,
                         @Bind("this") Node inliningTarget,
-                        @Exclusive @Cached PyLongCheckNode longCheckNode,
                         @Exclusive @Cached PointerNodes.PointerFromLongNode pointerFromLongNode,
-                        @Exclusive @Cached PointerNodes.WritePointerNode writePointerNode,
-                        @Exclusive @Cached PRaiseNode raiseNode) {
+                        @Exclusive @Cached PointerNodes.WritePointerNode writePointerNode) {
             Pointer valuePtr;
             if (value == PNone.NONE) {
                 valuePtr = Pointer.NULL;
-            } else if (longCheckNode.execute(inliningTarget, value)) {
-                valuePtr = pointerFromLongNode.execute(inliningTarget, value);
             } else {
-                throw raiseNode.raise(inliningTarget, TypeError, ErrorMessages.CANNOT_BE_CONVERTED_TO_POINTER);
+                valuePtr = pointerFromLongNode.execute(inliningTarget, value);
             }
-
             writePointerNode.execute(inliningTarget, ptr, valuePtr);
             return PNone.NONE;
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ctypes/memory/PointerNodes.java

@@ -41,9 +41,12 @@
 package com.oracle.graal.python.builtins.modules.ctypes.memory;
 
 import static com.oracle.graal.python.builtins.PythonBuiltinClassType.NotImplementedError;
+import static com.oracle.graal.python.builtins.PythonBuiltinClassType.OverflowError;
 import static com.oracle.graal.python.builtins.modules.ctypes.CtypesNodes.WCHAR_T_SIZE;
 import static com.oracle.graal.python.util.PythonUtils.ARRAY_ACCESSOR;
 
+import java.math.BigInteger;
+
 import com.oracle.graal.python.builtins.modules.ctypes.memory.Pointer.ByteArrayStorage;
 import com.oracle.graal.python.builtins.modules.ctypes.memory.Pointer.LongPointerStorage;
 import com.oracle.graal.python.builtins.modules.ctypes.memory.Pointer.MemoryBlock;
@@ -58,14 +61,15 @@
 import com.oracle.graal.python.builtins.objects.cext.PythonNativeVoidPtr;
 import com.oracle.graal.python.builtins.objects.cext.capi.CExtNodes;
 import com.oracle.graal.python.builtins.objects.cext.capi.transitions.CApiTransitions;
+import com.oracle.graal.python.builtins.objects.ints.PInt;
 import com.oracle.graal.python.builtins.objects.memoryview.PMemoryView;
 import com.oracle.graal.python.nodes.ErrorMessages;
 import com.oracle.graal.python.nodes.PRaiseNode;
-import com.oracle.graal.python.nodes.util.CastToJavaUnsignedLongNode;
 import com.oracle.graal.python.runtime.PythonContext;
 import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
+import com.oracle.truffle.api.HostCompilerDirectives.InliningCutoff;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateCached;
@@ -790,11 +794,36 @@ static Pointer doNativeVoidPtr(PythonNativeVoidPtr value) {
             return Pointer.nativeMemory(pointerObject);
         }
 
-        @Fallback
-        static Pointer doLong(Node inliningTarget, Object value,
-                        @Cached CastToJavaUnsignedLongNode cast) {
-            long pointer = cast.execute(inliningTarget, value);
-            return Pointer.nativeMemory(pointer);
+        @Specialization
+        static Pointer doBool(Node inliningTarget, boolean value) {
+            return Pointer.nativeMemory(value ? 1 : 0);
+        }
+
+        @Specialization
+        static Pointer doLong(Node inliningTarget, long value) {
+            return Pointer.nativeMemory(value);
+        }
+
+        @Specialization
+        static Pointer doPInt(Node inliningTarget, PInt value) {
+            return Pointer.nativeMemory(value.longValue());
+        }
+
+        @Specialization
+        @TruffleBoundary
+        @InliningCutoff
+        static Pointer doGeneric(Node inliningTarget, Object value,
+                        @CachedLibrary(limit = "1") InteropLibrary lib) {
+            if (lib.fitsInBigInteger(value)) {
+                BigInteger bi;
+                try {
+                    bi = lib.asBigInteger(value);
+                    return doLong(inliningTarget, bi.longValue());
+                } catch (UnsupportedMessageException e) {
+                    // fall through to error
+                }
+            }
+            throw PRaiseNode.raiseStatic(inliningTarget, OverflowError, ErrorMessages.CANNOT_BE_CONVERTED_TO_POINTER);
         }
     }