Fix swallowing exceptions from __repr__ in repl

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SysModuleBuiltins.java

@@ -1689,23 +1689,13 @@ static Object doHook(VirtualFrame frame, PythonModule sys, Object obj,
                 throw raiseNode.get(inliningTarget).raise(RuntimeError, LOST_S, "sys.stdout");
             }
 
-            boolean reprWriteOk = false;
-            boolean unicodeEncodeError = false;
+            Object reprVal = null;
             try {
-                Object reprVal = objectRepr(frame, inliningTarget, obj, reprAsObjectNode);
-                if (reprVal == null) {
-                    reprWriteOk = false;
-                } else {
-                    reprWriteOk = true;
-                    fileWriteString(frame, inliningTarget, stdOut, castToStringNode.execute(inliningTarget, reprVal), getAttr, callNode);
-                }
+                reprVal = objectRepr(frame, inliningTarget, obj, reprAsObjectNode);
             } catch (PException pe) {
                 pe.expect(inliningTarget, UnicodeEncodeError, unicodeEncodeErrorProfile);
                 // repr(o) is not encodable to sys.stdout.encoding with sys.stdout.errors error
                 // handler (which is probably 'strict')
-                unicodeEncodeError = true;
-            }
-            if (!reprWriteOk && unicodeEncodeError) {
                 // inlined sysDisplayHookUnencodable
                 final TruffleString stdoutEncoding = objectLookupAttrAsString(frame, inliningTarget, stdOut, T_ENCODING, lookupAttr, castToStringNode);
                 final Object reprStr = objectRepr(frame, inliningTarget, obj, reprAsObjectNode);
@@ -1720,6 +1710,9 @@ static Object doHook(VirtualFrame frame, PythonModule sys, Object obj,
                     fileWriteString(frame, inliningTarget, stdOut, castToStringNode.execute(inliningTarget, str), getAttr, callNode);
                 }
             }
+            if (reprVal != null) {
+                fileWriteString(frame, inliningTarget, stdOut, castToStringNode.execute(inliningTarget, reprVal), getAttr, callNode);
+            }
 
             fileWriteString(frame, inliningTarget, stdOut, T_NEWLINE, getAttr, callNode);
             setAttr.execute(frame, inliningTarget, builtins, T___, obj);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/lib/PyTraceBackPrintNode.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -151,11 +151,7 @@ public static Object objectRepr(VirtualFrame frame, Object value) {
     }
 
     public static Object objectRepr(VirtualFrame frame, Node inliningTarget, Object value, PyObjectReprAsObjectNode reprAsObjectNode) {
-        try {
-            return reprAsObjectNode.execute(frame, inliningTarget, value);
-        } catch (PException pe) {
-            return null;
-        }
+        return reprAsObjectNode.execute(frame, inliningTarget, value);
     }
 
     public static TruffleString castToString(Object value) {