Make sure source is never null

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

@@ -1210,7 +1210,8 @@ Object generic(VirtualFrame frame, Object wSource, Object wFilename, Object wMod
             }
             if (AstModuleBuiltins.isAst(getContext(), wSource)) {
                 ModTy mod = AstModuleBuiltins.obj2sst(getContext(), wSource);
-                Source source = createFakeSource();
+                // TODO _PyAST_Validate
+                Source source = PythonUtils.createFakeSource();
                 RootCallTarget rootCallTarget = getLanguage().compileForBytecodeInterpreter(getContext(), mod, source, false, optimize, null, null);
                 return wrapRootCallTarget(rootCallTarget);
             }
@@ -1219,11 +1220,6 @@ Object generic(VirtualFrame frame, Object wSource, Object wFilename, Object wMod
             return compile(source, filename, mode, flags, kwDontInherit, optimize);
         }
 
-        @TruffleBoundary
-        private Source createFakeSource() {
-            return Source.newBuilder(PythonLanguage.ID, "", "").build();
-        }
-
         private PCode wrapRootCallTarget(RootCallTarget rootCallTarget) {
             RootNode rootNode = rootCallTarget.getRootNode();
             if (rootNode instanceof PBytecodeRootNode) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/code/CodeNodes.java

@@ -152,7 +152,7 @@ private RootCallTarget deserializeForBytecodeInterpreter(PythonLanguage language
                                 code.outputCanQuicken, code.variableShouldUnbox,
                                 code.generalizeInputsMap, code.generalizeVarsMap);
             }
-            RootNode rootNode = PBytecodeRootNode.create(language, code, null);
+            RootNode rootNode = PBytecodeRootNode.create(language, code, PythonUtils.createFakeSource());
             if (code.isGeneratorOrCoroutine()) {
                 rootNode = new PBytecodeGeneratorFunctionRootNode(language, rootNode.getFrameDescriptor(), (PBytecodeRootNode) rootNode, code.name);
             }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/compiler/SourceMap.java

@@ -120,9 +120,7 @@ private static int readNum(ByteArrayInputStream offsets) {
     }
 
     public static SourceSection getSourceSection(Source source, int startLine, int startColumn, int endLine, int endColumn) {
-        if (source == null) {
-            return null;
-        } else if (!source.hasCharacters()) {
+        if (!source.hasCharacters()) {
             return source.createUnavailableSection();
         }
         try {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/bytecode/PBytecodeRootNode.java

@@ -597,6 +597,7 @@ public static PBytecodeRootNode create(PythonLanguage language, CodeUnit co, Sou
     @TruffleBoundary
     private PBytecodeRootNode(PythonLanguage language, FrameDescriptor fd, Signature sign, CodeUnit co, Source source, RaisePythonExceptionErrorCallback parserErrorCallback) {
         super(language, fd);
+        assert source != null;
         this.celloffset = co.varnames.length;
         this.freeoffset = celloffset + co.cellvars.length;
         this.stackoffset = freeoffset + co.freevars.length;
@@ -4987,8 +4988,6 @@ public int getFirstLineno() {
     public SourceSection getSourceSection() {
         if (sourceSection != null) {
             return sourceSection;
-        } else if (source == null) {
-            return null;
         } else if (!source.hasCharacters()) {
             /*
              * TODO We could still expose the disassembled bytecode for a debugger to have something

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/util/PythonUtils.java

@@ -60,8 +60,6 @@
 import javax.management.ObjectName;
 import javax.management.ReflectionException;
 
-import com.oracle.truffle.api.nodes.Node;
-import com.oracle.truffle.api.nodes.NodeVisitor;
 import org.graalvm.nativeimage.ImageInfo;
 
 import com.oracle.graal.python.PythonLanguage;
@@ -86,9 +84,12 @@
 import com.oracle.truffle.api.frame.Frame;
 import com.oracle.truffle.api.frame.MaterializedFrame;
 import com.oracle.truffle.api.memory.ByteArraySupport;
+import com.oracle.truffle.api.nodes.Node;
+import com.oracle.truffle.api.nodes.NodeVisitor;
 import com.oracle.truffle.api.nodes.RootNode;
 import com.oracle.truffle.api.profiles.ConditionProfile;
 import com.oracle.truffle.api.profiles.ValueProfile;
+import com.oracle.truffle.api.source.Source;
 import com.oracle.truffle.api.strings.TruffleString;
 import com.oracle.truffle.api.strings.TruffleString.Encoding;
 
@@ -689,6 +690,11 @@ public static TruffleString[] objectArrayToTruffleStringArray(Object[] array, Ca
         return result;
     }
 
+    @TruffleBoundary
+    public static Source createFakeSource() {
+        return Source.newBuilder(PythonLanguage.ID, "", "").build();
+    }
+
     public static final class NodeCounterWithLimit implements NodeVisitor {
         private int count;
         private final int limit;