OSDP_CMD_OUTPUT always sends ACK

[aligu24]

OSDP_CMD_OUTPUT always sends ACK

Describe the bug
In the command handler when you return -1, it doesn't response with NAK. It's same when capability has 2 outputs and you are trying to set 5th output, it still sends ACK. It is same for CMD_LED command too, there may be others.

Expected behavior
It should return NAK when command handler returns error or when capability check returns error. In the below logs I tried to set output 5 and it returned ACK.

A Comprehensive Log file
OSDP.Net ACU Console
11:10:44.362 - System: Output Control Command for address 0
Ack

---

11:10:18.509 - System: Device capabilities for address 0
Function: Contact Status Monitoring
Compliance: 2
Number Of: 6

Function: Output Control
Compliance: 3
Number Of: 2

Function: Reader LED Control
Compliance: 3
Number Of: 2

Function: Check Character Support
Compliance: 1
Number Of: 0

Function: Communication Security
Supports AES-128: True
Uses Default Key: False

Function: Receive Buffer Size
Size: 256

Function: Largest Combined Message Size
Size: 128

Function: OSDP Version
Compliance: 2
Number Of: 0

[sidcha]

Hi, can you also report which version of LibOSDP you are using and in what mode.

[aligu24]

I am using v3.2.5 version of LibOSDP as PD.

[sidcha]

Noted, in the meantime can you please try the latest master and see if that works? There has been a LOT of fixes to LibOSDP in preparation for v4.0 and you can quickly unblock yourself while I investigate this issue.