Skip to content

RtmpUint16 UnmarshalBinary incorrect byteorder #55

@avfedorov

Description

@avfedorov

Byteorder in protocol.RtmpUint16 UnmarshalBinary is incorrect.
Current:
*v = RtmpUint16(uint16(data[0]) | uint16(data[1])<<8)
Must be:
*v = RtmpUint16(uint16(data[1]) | uint16(data[0])<<8)

This leads to an incorrect decoding of UserControlMessage for example.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions