Skip to content

Commit 3fe910c

Browse files
committed
feat(CC-batch-6): @kmcfaul review 7 updates
1 parent b1ecf97 commit 3fe910c

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

packages/code-connect/components/JumpLinks/JumplinksHorizontal.figma.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ figma.connect(
1616

1717
children: figma.children('*')
1818
},
19-
example: (props) => <JumpLinks label={props.label}>{props.children}</JumpLinks>
19+
example: (props) => (
20+
<JumpLinks aria-label={props.label} label={props.label}>
21+
{props.children}
22+
</JumpLinks>
23+
)
2024
}
2125
);

packages/code-connect/components/JumpLinks/JumplinksVertical.figma.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ figma.connect(
1717
children: figma.children('*')
1818
},
1919
example: (props) => (
20-
<JumpLinks isVertical label={props.label}>
20+
<JumpLinks aria-label={props.label} isVertical label={props.label}>
2121
{props.children}
2222
</JumpLinks>
2323
)

packages/code-connect/components/Label/LabelGroups.figma.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ figma.connect(
88
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=2800-1075',
99
{
1010
props: {
11-
// string
12-
labelGroupName: figma.string('Label group name'),
13-
1411
// boolean
1512
numLabels: figma.boolean('Has collapsed labels', {
1613
true: 4,

packages/code-connect/components/Modal/AlertModal.figma.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ figma.connect(
6969
aria-labelledby="<modal-id>"
7070
aria-describedby="<modal-body>"
7171
isOpen={true}
72-
onClick={() => {
72+
onClose={() => {
7373
setIsOpen(!isOpen);
7474
}}
7575
variant={props.variant}

packages/code-connect/components/Modal/BasicModal.figma.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,23 +46,23 @@ figma.connect(
4646
},
4747
example: (props) => {
4848
/* eslint-disable */
49-
const [isOpen, setIsOpen] = React.useState(false);
49+
const [isModalOpen, setIsOpen] = React.useState(false);
5050
/* eslint-enable */
5151

5252
return (
5353
<>
5454
<Button
5555
variant="primary"
5656
onClick={() => {
57-
setIsOpen(!isOpen);
57+
setIsModalOpen(!isModalOpen);
5858
}}
5959
>
6060
Show about modal
6161
</Button>
6262
<Modal
6363
aria-labelledby="<modal-id>"
6464
aria-describedby="<modal-body>"
65-
isOpen={true}
65+
isOpen={isModalOpen}
6666
onClose={() => {}} // handles the close button
6767
variant={props.variant}
6868
>

0 commit comments

Comments
 (0)