Skip to content

Commit fb7ed13

Browse files
committed
feat(CC-batch-6): group review 9/23 updates
1 parent 4e8046b commit fb7ed13

File tree

3 files changed

+28
-29
lines changed

3 files changed

+28
-29
lines changed
Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,28 @@
11
import figma from '@figma/code-connect';
2-
import { Label } from '@patternfly/react-core';
2+
import { Badge, Label } from '@patternfly/react-core';
33

44
// TODO: DESIGN: Reconfigure how numlabels is set. Currently, the text string "more" is not customizable
55
// TODO: DESIGN: Label group should contain label components
66

77
// NOTE: "Label overflow" doesn't appear to be necessary
88
// Documentation for Label can be found at https://www.patternfly.org/components/label-group
99

10-
figma.connect(
11-
Label,
12-
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=2800-1067',
13-
{
14-
props: {
15-
labelText: figma.string('Label text'),
16-
isCloseable: figma.boolean('Has Close button', {
17-
true: `{() => {}}`,
18-
false: undefined
19-
})
20-
},
21-
example: (props) => <Label onClose={props.isCloseable}>{props.labelText}</Label>
22-
}
23-
);
10+
figma.connect(Label, 'https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components?node-id=2800-1067', {
11+
props: {
12+
labelText: figma.string('Label text'),
13+
isCloseable: figma.boolean('Has Close button', {
14+
true: `{() => {}}`,
15+
false: undefined
16+
}),
17+
badge: figma.boolean('Has counter', {
18+
true: <Badge>06</Badge>,
19+
false: undefined
20+
})
21+
},
22+
example: (props) => (
23+
<Label onClose={props.isCloseable}>
24+
{props.labelText}
25+
{props.badge}
26+
</Label>
27+
)
28+
});

packages/code-connect/components/Label/LabelOverflow.figma.tsx

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/code-connect/figma.config.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,19 @@
22
"codeConnect": {
33
"parser": "react",
44
"include": [
5-
"components/Masthead/*.figma.tsx"
5+
"components/JumpLinks/*.figma.tsx",
6+
"components/Label/*.figma.tsx",
7+
"components/LoginPage/*.figma.tsx",
8+
"components/Masthead/*.figma.tsx",
9+
"components/Model/*.figma.tsx"
610
],
711
"paths": {
812
"@patternfly/react-core": "/Users/mnolting/Web/patternfly-react/packages/react-core/src",
913
"@patternfly/react-table": "/Users/mnolting/Web/patternfly-react/packages/react-table/src"
1014
},
15+
"documentUrlSubstitutions": {
16+
"https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/PatternFly-6--Components": "https://www.figma.com/design/VMEX8Xg2nzhBX8rfBx53jp/branch/Em2QWrHDxDS4LUxo58Hust/PatternFly-6--Components"
17+
},
1118
"aliases": {
1219
"@patternfly/react-core": "/Users/mnolting/Web/patternfly-react/packages/react-core/src",
1320
"@patternfly/react-table": "/Users/mnolting/Web/patternfly-react/packages/react-table/src"

0 commit comments

Comments
 (0)