From 8adc5ce543f99c592fc8620340b06dd4c7f0759d Mon Sep 17 00:00:00 2001 From: Titani Date: Wed, 22 Apr 2026 08:34:50 -0400 Subject: [PATCH] chore(Star Icons): Replace all star FA icons with RH brand star icons --- packages/react-core/src/components/Button/Button.tsx | 8 ++++---- packages/react-icons/scripts/icons/pfToRhIcons.mjs | 3 ++- .../src/components/Table/utils/decorators/sortable.tsx | 4 ++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/react-core/src/components/Button/Button.tsx b/packages/react-core/src/components/Button/Button.tsx index 80564bc44b4..64cb4db6c71 100644 --- a/packages/react-core/src/components/Button/Button.tsx +++ b/packages/react-core/src/components/Button/Button.tsx @@ -4,8 +4,8 @@ import { css } from '@patternfly/react-styles'; import { Spinner, spinnerSize } from '../Spinner'; import { useOUIAProps, OUIAProps } from '../../helpers/OUIA/ouia'; import { Badge } from '../Badge'; -import StarIcon from '@patternfly/react-icons/dist/esm/icons/star-icon'; -import OutlinedStarIcon from '@patternfly/react-icons/dist/esm/icons/outlined-star-icon'; +import RhUiStarFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-star-fill-icon'; +import RhUiStarIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-star-icon'; import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import { hamburgerIcon } from './hamburgerIcon'; @@ -211,10 +211,10 @@ const ButtonBase: React.FunctionComponent = ({ iconContent = ( <> - + - + ); diff --git a/packages/react-icons/scripts/icons/pfToRhIcons.mjs b/packages/react-icons/scripts/icons/pfToRhIcons.mjs index fcc85253194..8ca56b7a3b3 100644 --- a/packages/react-icons/scripts/icons/pfToRhIcons.mjs +++ b/packages/react-icons/scripts/icons/pfToRhIcons.mjs @@ -104,6 +104,7 @@ export const pfToRhIcons = { OutlinedCommentsIcon: { name: 'rh-ui-comments', icon: getIconData('rh-ui-comments') }, OutlinedHddIcon: { name: 'rh-ui-hard-drive', icon: getIconData('rh-ui-hard-drive') }, OutlinedQuestionCircleIcon: { name: 'rh-ui-question-mark-circle', icon: getIconData('rh-ui-question-mark-circle') }, + OutlinedStarIcon: { name: 'rh-ui-star', icon: getIconData('rh-ui-star') }, OutlinedWindowRestoreIcon: { name: 'rh-ui-restore-window', icon: getIconData('rh-ui-restore-window') }, PackageIcon: { name: 'rh-ui-package', icon: getIconData('rh-ui-package') }, PauseCircleIcon: { name: 'rh-ui-pause-circle', icon: getIconData('rh-ui-pause-circle') }, @@ -151,7 +152,7 @@ export const pfToRhIcons = { icon: getIconData('rh-ui-sort-down-small-to-large') }, SortAmountDownIcon: { name: 'rh-ui-sort-down-large-to-small', icon: getIconData('rh-ui-sort-down-large-to-small') }, - StarIcon: { name: 'rh-ui-star', icon: getIconData('rh-ui-star') }, + StarIcon: { name: 'rh-ui-star-fill', icon: getIconData('rh-ui-star-fill') }, StorageDomainIcon: { name: 'rh-ui-storage-domain', icon: getIconData('rh-ui-storage-domain') }, SyncAltIcon: { name: 'rh-ui-sync', icon: getIconData('rh-ui-sync') }, TableIcon: { name: 'rh-ui-table', icon: getIconData('rh-ui-table') }, diff --git a/packages/react-table/src/components/Table/utils/decorators/sortable.tsx b/packages/react-table/src/components/Table/utils/decorators/sortable.tsx index aaed3ae3660..6379485fc58 100644 --- a/packages/react-table/src/components/Table/utils/decorators/sortable.tsx +++ b/packages/react-table/src/components/Table/utils/decorators/sortable.tsx @@ -2,10 +2,10 @@ import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Table/table'; import { IExtra, IFormatterValueType, ITransform } from '../../TableTypes'; import { SortColumn, SortByDirection } from '../../SortColumn'; -import StarIcon from '@patternfly/react-icons/dist/esm/icons/star-icon'; +import RhUiStarFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-star-fill-icon'; export const sortableFavorites = (sort: any) => () => - sortable(, { + sortable(, { columnIndex: sort.columnIndex, className: styles.tableFavorite, ariaLabel: sort.ariaLabel ?? 'Sort favorites',