From dd1fa6445e7ef63acd5729cae96a1e8c1fe23881 Mon Sep 17 00:00:00 2001 From: monsieurleberre Date: Wed, 2 Sep 2026 08:50:13 +0100 Subject: [PATCH] ci(publish): default the damlc component to 3.5.2 The DAR publish pipeline declared damlc 3.4.11 while every archive it processes is newer: the vendored Splice DARs embed Sdk-Version 3.5.2, and all six daml.yaml files in this repo pin sdk-version: 3.5.2. The component is written into a generated dpm-workspace/daml.yaml alongside the dpm-codegen-cs OCI bundle, and it is the bundle -- not damlc -- that reads the DARs, so this was never miscompiling anything. It did leave the pipeline's stated contract untrue, and there is no way to correct it at release time: release.yaml passes no damlc_version to either DAR leg, so these defaults are the effective value on a tag push. The literal was duplicated across seven sites -- both triggers of each publish workflow, the shared reusable, and resolve-inputs.sh (the actual runtime fallback, plus its usage text). No 3.4.11 remains under .github/. 3.5.2 is the newest damlc that exists: it is the highest tag under components/damlc, and the 3.5, devnet, testnet and mainnet channel tags all resolve to it. daml-script, driven by the same input, tops out there too. --- .github/scripts/resolve-inputs.sh | 4 ++-- .github/workflows/_publish-dar-packages.yaml | 2 +- .github/workflows/publish-daml-finance.yaml | 4 ++-- .github/workflows/publish-splice.yaml | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/scripts/resolve-inputs.sh b/.github/scripts/resolve-inputs.sh index 120535f..2cbf299 100755 --- a/.github/scripts/resolve-inputs.sh +++ b/.github/scripts/resolve-inputs.sh @@ -14,7 +14,7 @@ Directory.Build.props , and export the resolved values to \$GITHUB_ENV. Reads (env): RUNTIME_VERSION_INPUT Daml.Runtime version; empty => Directory.Build.props . CODEGEN_CS_VERSION_INPUT codegen-cs version; empty => Directory.Build.props . - DAMLC_VERSION_INPUT damlc component version (default: 3.4.11). + DAMLC_VERSION_INPUT damlc component version (default: 3.5.2). PACKAGE_LICENSE_INPUT SPDX license expression (default: Apache-2.0). DRY_RUN_INPUT dry-run flag, passed through verbatim. SOURCE_LABEL Short label used in the resolved-summary line. @@ -40,7 +40,7 @@ EFFECTIVE_CODEGEN_CS="${CODEGEN_CS_VERSION_INPUT:-}" if [ -z "$EFFECTIVE_CODEGEN_CS" ]; then EFFECTIVE_CODEGEN_CS=$(grep -oP '(?<=)[^<]+' "$REPO_ROOT/Directory.Build.props" | head -1 || true) fi -EFFECTIVE_DAMLC="${DAMLC_VERSION_INPUT:-3.4.11}" +EFFECTIVE_DAMLC="${DAMLC_VERSION_INPUT:-3.5.2}" EFFECTIVE_PACKAGE_LICENSE="${PACKAGE_LICENSE_INPUT:-Apache-2.0}" EFFECTIVE_DRY_RUN="${DRY_RUN_INPUT:-}" diff --git a/.github/workflows/_publish-dar-packages.yaml b/.github/workflows/_publish-dar-packages.yaml index 9f45744..1e0e5d7 100644 --- a/.github/workflows/_publish-dar-packages.yaml +++ b/.github/workflows/_publish-dar-packages.yaml @@ -32,7 +32,7 @@ on: description: 'damlc component version listed under daml.yaml components.' required: false type: string - default: '3.4.11' + default: '3.5.2' runtime_version: description: 'Daml.Runtime NuGet version referenced from generated csprojs. Empty = Directory.Build.props .' required: false diff --git a/.github/workflows/publish-daml-finance.yaml b/.github/workflows/publish-daml-finance.yaml index 7c1246f..3311431 100644 --- a/.github/workflows/publish-daml-finance.yaml +++ b/.github/workflows/publish-daml-finance.yaml @@ -17,7 +17,7 @@ on: description: 'damlc component version listed under daml.yaml components.' required: false type: string - default: '3.4.11' + default: '3.5.2' runtime_version: description: 'Daml.Runtime NuGet version referenced from generated csprojs. Empty = Directory.Build.props .' required: false @@ -59,7 +59,7 @@ on: description: 'damlc component version listed under daml.yaml components.' required: false type: string - default: '3.4.11' + default: '3.5.2' runtime_version: description: 'Daml.Runtime NuGet version referenced from generated csprojs. Empty = Directory.Build.props .' required: false diff --git a/.github/workflows/publish-splice.yaml b/.github/workflows/publish-splice.yaml index cd921cb..d525c96 100644 --- a/.github/workflows/publish-splice.yaml +++ b/.github/workflows/publish-splice.yaml @@ -16,7 +16,7 @@ on: description: 'damlc component version listed under daml.yaml components.' required: false type: string - default: '3.4.11' + default: '3.5.2' runtime_version: description: 'Daml.Runtime NuGet version referenced from generated csprojs. Empty = Directory.Build.props .' required: false @@ -57,7 +57,7 @@ on: description: 'damlc component version listed under daml.yaml components.' required: false type: string - default: '3.4.11' + default: '3.5.2' runtime_version: description: 'Daml.Runtime NuGet version referenced from generated csprojs. Empty = Directory.Build.props .' required: false