Added checks to from_binary [skip ci]

Author: ankane

pgvector/bit.py

@@ -89,6 +89,11 @@ def from_binary(cls, value: bytes) -> Bit:
         if not isinstance(value, bytes):
             raise ValueError('expected bytes')
 
+        length, = unpack_from('>i', value)
+
+        if len(value) != 4 + (length + 7) // 8:
+            raise ValueError('invalid length')
+
         bit = cls.__new__(cls)
         bit._value = value
         return bit

pgvector/halfvec.py

@@ -58,7 +58,14 @@ def from_text(cls, value: str) -> HalfVector:
 
     @classmethod
     def from_binary(cls, value: bytes) -> HalfVector:
-        # TODO check dimensions/length and unused
+        dim, unused = struct.unpack_from('>HH', value)
+
+        if len(value) != 4 + 2 * dim:
+            raise ValueError('invalid length')
+
+        if unused != 0:
+            raise ValueError('expected unused to be 0')
+
         vec = cls.__new__(cls)
         vec._value = value
         return vec

pgvector/vector.py

@@ -58,7 +58,14 @@ def from_text(cls, value: str) -> Vector:
 
     @classmethod
     def from_binary(cls, value: bytes) -> Vector:
-        # TODO check dimensions/length and unused
+        dim, unused = struct.unpack_from('>HH', value)
+
+        if len(value) != 4 + 4 * dim:
+            raise ValueError('invalid length')
+
+        if unused != 0:
+            raise ValueError('expected unused to be 0')
+
         vec = cls.__new__(cls)
         vec._value = value
         return vec