feat: GET responds with 404 error when database returned empty result

Author: php-coder

examples/js/app.js

@@ -33,6 +33,10 @@ app.get('/v1/categories/count', (req, res) => {
             if (err) {
                 throw err
             }
+            if (rows.length === 0) {
+                res.type('application/json').status(404).end()
+                return
+            }
             res.json(rows[0])
         }
     )
@@ -46,6 +50,10 @@ app.get('/v1/collections/:collectionId/categories/count', (req, res) => {
             if (err) {
                 throw err
             }
+            if (rows.length === 0) {
+                res.type('application/json').status(404).end()
+                return
+            }
             res.json(rows[0])
         }
     )
@@ -64,6 +72,23 @@ app.post('/v1/categories', (req, res) => {
     )
 })
 
+app.get('/v1/categories/:categoryId', (req, res) => {
+    pool.query(
+        'SELECT id , name , name_ru , slug FROM categories WHERE id = :categoryId',
+        { "categoryId": req.params.categoryId },
+        (err, rows, fields) => {
+            if (err) {
+                throw err
+            }
+            if (rows.length === 0) {
+                res.type('application/json').status(404).end()
+                return
+            }
+            res.json(rows[0])
+        }
+    )
+})
+
 app.put('/v1/categories/:categoryId', (req, res) => {
     pool.query(
         'UPDATE categories SET name = :name , name_ru = :nameRu , slug = :slug , updated_at = NOW() , updated_by = :userId WHERE id = :categoryId',

examples/js/endpoints.yaml

@@ -32,6 +32,13 @@
         )
 
 - path: /v1/categories/:categoryId
+  get: >-
+    SELECT id
+         , name
+         , name_ru
+         , slug
+      FROM categories
+     WHERE id = :categoryId
   put: >-
     UPDATE categories
        SET name = :name

src/templates/app.js.ejs

@@ -37,6 +37,10 @@ app.get('<%- endpoint.path %>', (req, res) => {
             if (err) {
                 throw err
             }
+            if (rows.length === 0) {
+                res.type('application/json').status(404).end()
+                return
+            }
             res.json(rows[0])
         }
     )

tests/crud.robot

@@ -14,6 +14,11 @@ GET should return a value
     Status Should Be                200  ${response}
     Dictionary Should Contain Item  ${response.json()}  counter  0
 
+GET should return not found
+    ${response}=      Get Request  api  /v1/categories/100
+    Status Should Be  404  ${response}
+    Should Be Equal   ${response.headers['Content-Type']}  application/json; charset=utf-8
+
 POST should create an object
     &{payload}=                     Create Dictionary  name=Sport  slug=sport  userId=1
     ${response}=                    Post Request  api  /v1/categories  json=${payload}