From 7ade0a0b2a51b41bc2de20fad8521b8a9156f1f0 Mon Sep 17 00:00:00 2001
From: ekes <ekes@iskra.net>
Date: Mon, 18 May 2026 12:02:45 +0200
Subject: [PATCH 1/4] Return value for IntlDatePatternGenerator::getBestPattern
 is for IntlDateFormatter

Correcting from suggestion it was a format for DateTime.
---
 reference/intl/intldatepatterngenerator/getbestpattern.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/reference/intl/intldatepatterngenerator/getbestpattern.xml b/reference/intl/intldatepatterngenerator/getbestpattern.xml
index 17dd820035ae..e5c7c157257d 100644
--- a/reference/intl/intldatepatterngenerator/getbestpattern.xml
+++ b/reference/intl/intldatepatterngenerator/getbestpattern.xml
@@ -33,7 +33,7 @@
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
-   Returns a format, accepted by <methodname>DateTimeInterface::format</methodname> on success, &return.falseforfailure;.
+   Returns a pattern, accepted by <methodname>IntlDateFormatter::create</methodname> on success, &return.falseforfailure;.
   </para>
  </refsect1>
 

From f290544264d46e8577cfead3e9a4ff7c99ddc69d Mon Sep 17 00:00:00 2001
From: ekes <ekes@iskra.net>
Date: Wed, 20 May 2026 14:35:34 +0200
Subject: [PATCH 2/4] Update
 reference/intl/intldatepatterngenerator/getbestpattern.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
---
 reference/intl/intldatepatterngenerator/getbestpattern.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/reference/intl/intldatepatterngenerator/getbestpattern.xml b/reference/intl/intldatepatterngenerator/getbestpattern.xml
index e5c7c157257d..e3ed9f3f8aaa 100644
--- a/reference/intl/intldatepatterngenerator/getbestpattern.xml
+++ b/reference/intl/intldatepatterngenerator/getbestpattern.xml
@@ -33,7 +33,7 @@
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
-   Returns a pattern, accepted by <methodname>IntlDateFormatter::create</methodname> on success, &return.falseforfailure;.
+   Returns a pattern accepted by <classname>IntlDateFormatter</classname> on success, &return.falseforfailure;.
   </para>
  </refsect1>
 

From ce8e6d213b21c56ac18509fc96baa2aa39ade818 Mon Sep 17 00:00:00 2001
From: ekes <ekes@iskra.net>
Date: Wed, 20 May 2026 14:37:43 +0200
Subject: [PATCH 3/4] Apply suggestions from code review

Had to look this up, but yes it's what is being standardized to.

Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
---
 reference/intl/intldatepatterngenerator/getbestpattern.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/reference/intl/intldatepatterngenerator/getbestpattern.xml b/reference/intl/intldatepatterngenerator/getbestpattern.xml
index e3ed9f3f8aaa..9717e27a7eff 100644
--- a/reference/intl/intldatepatterngenerator/getbestpattern.xml
+++ b/reference/intl/intldatepatterngenerator/getbestpattern.xml
@@ -32,9 +32,9 @@
 
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
-  <para>
+  <simpara>
    Returns a pattern accepted by <classname>IntlDateFormatter</classname> on success, &return.falseforfailure;.
-  </para>
+  </simpara>
  </refsect1>
 
  <refsect1 role="examples">

From 1711048417fc2c00213839c1a01c202e6a6897e7 Mon Sep 17 00:00:00 2001
From: ekes <ekes@iskra.net>
Date: Wed, 20 May 2026 14:45:29 +0200
Subject: [PATCH 4/4] Specify it is a ICU date/time pattern

Applying suggestion @lacatoire https://github.com/php/doc-en/pull/5567#discussion_r3272184597
---
 reference/intl/intldatepatterngenerator/getbestpattern.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/reference/intl/intldatepatterngenerator/getbestpattern.xml b/reference/intl/intldatepatterngenerator/getbestpattern.xml
index 9717e27a7eff..83216557e42f 100644
--- a/reference/intl/intldatepatterngenerator/getbestpattern.xml
+++ b/reference/intl/intldatepatterngenerator/getbestpattern.xml
@@ -33,7 +33,7 @@
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <simpara>
-   Returns a pattern accepted by <classname>IntlDateFormatter</classname> on success, &return.falseforfailure;.
+   Returns an ICU date/time pattern accepted by <classname>IntlDateFormatter</classname> on success, &return.falseforfailure;.
   </simpara>
  </refsect1>