Do not complain about properties with missing and broken types

Author: ondrejmirtes

src/Rules/Doctrine/ORM/EntityColumnRule.php

@@ -9,6 +9,9 @@
 use PHPStan\Type\Doctrine\DescriptorNotRegisteredException;
 use PHPStan\Type\Doctrine\DescriptorRegistry;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
+use PHPStan\Type\ErrorType;
+use PHPStan\Type\MixedType;
+use PHPStan\Type\NeverType;
 use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\VerbosityLevel;
 use Throwable;
@@ -112,7 +115,12 @@ public function processNode(Node $node, Scope $scope): array
 			$writableToDatabaseType = TypeCombinator::addNull($writableToDatabaseType);
 		}
 
-		if (!$property->getWritableType()->isSuperTypeOf($writableToPropertyType)->yes()) {
+		$propertyWritableType = $property->getWritableType();
+		if (get_class($propertyWritableType) === MixedType::class || $propertyWritableType instanceof ErrorType || $propertyWritableType instanceof NeverType) {
+			return [];
+		}
+
+		if (!$propertyWritableType->isSuperTypeOf($writableToPropertyType)->yes()) {
 			$errors[] = sprintf(
 				'Property %s::$%s type mapping mismatch: database can contain %s but property expects %s.',
 				$className,

src/Rules/Doctrine/ORM/EntityRelationRule.php

@@ -7,8 +7,10 @@
 use PHPStan\Reflection\MissingPropertyFromReflectionException;
 use PHPStan\Rules\Rule;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
+use PHPStan\Type\ErrorType;
 use PHPStan\Type\IterableType;
 use PHPStan\Type\MixedType;
+use PHPStan\Type\NeverType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\VerbosityLevel;
@@ -97,7 +99,11 @@ public function processNode(Node $node, Scope $scope): array
 
 		$errors = [];
 		if ($columnType !== null) {
-			if (!$property->getWritableType()->isSuperTypeOf($columnType)->yes()) {
+			$propertyWritableType = $property->getWritableType();
+			if (get_class($propertyWritableType) === MixedType::class || $propertyWritableType instanceof ErrorType || $propertyWritableType instanceof NeverType) {
+				return [];
+			}
+			if (!$propertyWritableType->isSuperTypeOf($columnType)->yes()) {
 				$errors[] = sprintf(
 					'Property %s::$%s type mapping mismatch: database can contain %s but property expects %s.',
 					$className,

tests/Rules/Doctrine/ORM/data/EntityWithRelations.php

@@ -41,4 +41,15 @@ class EntityWithRelations
 	 */
 	private $manyToMany;
 
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 */
+	private $mixed;
+
+	/**
+	 * @ORM\ManyToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var int&string
+	 */
+	private $never;
+
 }

tests/Rules/Doctrine/ORM/data/MyBrokenEntity.php

@@ -48,4 +48,15 @@ class MyBrokenEntity extends MyBrokenSuperclass
 	 */
 	private $six;
 
+	/**
+	 * @ORM\Column(type="date")
+	 */
+	private $mixed;
+
+	/**
+	 * @ORM\Column(type="date")
+	 * @var int&string
+	 */
+	private $never;
+
 }