Catch MappingException in GetRepositoryDynamicReturnTypeExtension

Author: ondrejmirtes

src/Type/Doctrine/GetRepositoryDynamicReturnTypeExtension.php

@@ -65,7 +65,11 @@ public function getTypeFromMethodCall(
 			return $this->getDefaultReturnType($scope, $methodCall->args, $methodReflection);
 		}
 
-		$repositoryClass = $this->metadataResolver->getRepositoryClass($objectName);
+		try {
+			$repositoryClass = $this->metadataResolver->getRepositoryClass($objectName);
+		} catch (\Doctrine\ORM\Mapping\MappingException $e) {
+			return $this->getDefaultReturnType($scope, $methodCall->args, $methodReflection);
+		}
 
 		return new GenericObjectType($repositoryClass, [
 			$classType,

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn-0.json

@@ -1,12 +1,12 @@
 [
     {
         "message": "Call to method Doctrine\\ORM\\EntityRepository<PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity>::findOneBy() - entity PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity does not have a field named $blah.",
-        "line": 93,
+        "line": 94,
         "ignorable": true
     },
     {
         "message": "Call to method Doctrine\\ORM\\EntityRepository<PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity>::findBy() - entity PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity does not have a field named $blah.",
-        "line": 115,
+        "line": 116,
         "ignorable": true
     }
 ]

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn-2.json

@@ -1,47 +1,47 @@
 [
     {
         "message": "Call to an undefined method PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity::doSomethingElse().",
-        "line": 88,
+        "line": 89,
         "ignorable": true
     },
     {
         "message": "Call to an undefined method PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity::doSomethingElse().",
-        "line": 100,
+        "line": 101,
         "ignorable": true
     },
     {
         "message": "Call to an undefined method PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity::doSomethingElse().",
-        "line": 109,
+        "line": 110,
         "ignorable": true
     },
     {
         "message": "Call to an undefined method PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity::doSomethingElse().",
-        "line": 119,
+        "line": 120,
         "ignorable": true
     },
     {
         "message": "Call to an undefined method PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity::doSomethingElse().",
-        "line": 141,
+        "line": 142,
         "ignorable": true
     },
     {
         "message": "Call to an undefined method Doctrine\\ORM\\EntityRepository<PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity>::findByNonexistent().",
-        "line": 147,
+        "line": 148,
         "ignorable": true
     },
     {
         "message": "Call to an undefined method PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity::doSomethingElse().",
-        "line": 159,
+        "line": 160,
         "ignorable": true
     },
     {
         "message": "Call to an undefined method Doctrine\\ORM\\EntityRepository<PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity>::findOneByNonexistent().",
-        "line": 164,
+        "line": 165,
         "ignorable": true
     },
     {
         "message": "Call to an undefined method Doctrine\\ORM\\EntityRepository<PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\MyEntity>::countByNonexistent().",
-        "line": 173,
+        "line": 174,
         "ignorable": true
     }
 ]

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn-4.json

@@ -1,7 +1,7 @@
 [
     {
         "message": "Strict comparison using === between int and 'foo' will always evaluate to false.",
-        "line": 170,
+        "line": 171,
         "ignorable": true
     }
 ]

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn-5.json

@@ -1,7 +1,7 @@
 [
     {
         "message": "Parameter #1 $className of method Doctrine\\Persistence\\ObjectManager::getRepository() expects class-string<nonexistentClass>, string given.",
-        "line": 211,
+        "line": 212,
         "ignorable": true
     }
 ]

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn-6.json

@@ -1,7 +1,7 @@
 [
     {
         "message": "Property PHPStan\\DoctrineIntegration\\ORM\\EntityRepositoryDynamicReturn\\Example::$repository with generic class Doctrine\\ORM\\EntityRepository does not specify its types: TEntityClass",
-        "line": 15,
+        "line": 16,
         "ignorable": true
     }
 ]

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\DoctrineIntegration\ORM\EntityRepositoryDynamicReturn;
 
+use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\EntityRepository;
 use Doctrine\ORM\Mapping as ORM;
@@ -212,3 +213,18 @@ public function doBar(EntityManagerInterface $entityManager): void
 	}
 
 }
+
+abstract class BaseEntity
+{
+
+	/**
+	 * @return EntityRepository<self>
+	 */
+	public function getRepository(): EntityRepository
+	{
+		return $this->getEntityManager()->getRepository(static::class);
+	}
+
+	abstract public function getEntityManager(): EntityManager;
+
+}