Fix $entityManager->getRepository() with non-classes

Author: ondrejmirtes

src/Type/Doctrine/ObjectMetadataResolver.php

@@ -3,12 +3,16 @@
 namespace PHPStan\Type\Doctrine;
 
 use Doctrine\Common\Persistence\ObjectManager;
+use PHPStan\Reflection\ReflectionProvider;
 use function file_exists;
 use function is_readable;
 
 final class ObjectMetadataResolver
 {
 
+	/** @var ReflectionProvider */
+	private $reflectionProvider;
+
 	/** @var string|null */
 	private $objectManagerLoader;
 
@@ -21,8 +25,13 @@ final class ObjectMetadataResolver
 	/** @var string|null */
 	private $resolvedRepositoryClass;
 
-	public function __construct(?string $objectManagerLoader, ?string $repositoryClass)
+	public function __construct(
+		ReflectionProvider $reflectionProvider,
+		?string $objectManagerLoader,
+		?string $repositoryClass
+	)
 	{
+		$this->reflectionProvider = $reflectionProvider;
 		$this->objectManagerLoader = $objectManagerLoader;
 		$this->repositoryClass = $repositoryClass;
 	}
@@ -83,6 +92,15 @@ public function getRepositoryClass(string $className): string
 			return $this->getResolvedRepositoryClass();
 		}
 
+		if (!$this->reflectionProvider->hasClass($className)) {
+			return $this->getResolvedRepositoryClass();
+		}
+
+		$classReflection = $this->reflectionProvider->getClass($className);
+		if ($classReflection->isInterface() || $classReflection->isTrait()) {
+			return $this->getResolvedRepositoryClass();
+		}
+
 		$metadata = $objectManager->getClassMetadata($className);
 
 		$ormMetadataClass = 'Doctrine\ORM\Mapping\ClassMetadata';

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn-5.json

@@ -0,0 +1,7 @@
+[
+    {
+        "message": "Parameter #1 $className of method Doctrine\\Persistence\\ObjectManager::getRepository() expects class-string<nonexistentClass>, string given.",
+        "line": 211,
+        "ignorable": true
+    }
+]

tests/DoctrineIntegration/ORM/data/entityRepositoryDynamicReturn.php

@@ -192,3 +192,23 @@ public function doSomething(): void
 	{
 	}
 }
+
+interface EntityInterface
+{
+
+}
+
+class GetRepositoryOnNonClasses
+{
+
+	public function doFoo(EntityManagerInterface $entityManager): void
+	{
+		$entityManager->getRepository(EntityInterface::class);
+	}
+
+	public function doBar(EntityManagerInterface $entityManager): void
+	{
+		$entityManager->getRepository('nonexistentClass');
+	}
+
+}

tests/Rules/Doctrine/ORM/DqlRuleTest.php

@@ -14,7 +14,7 @@ class DqlRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new DqlRule(new ObjectMetadataResolver(__DIR__ . '/entity-manager.php', null));
+		return new DqlRule(new ObjectMetadataResolver($this->createReflectionProvider(), __DIR__ . '/entity-manager.php', null));
 	}
 
 	public function testRule(): void

tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php

@@ -36,7 +36,7 @@ protected function getRule(): Rule
 		}
 
 		return new EntityColumnRule(
-			new ObjectMetadataResolver(__DIR__ . '/entity-manager.php', null),
+			new ObjectMetadataResolver($this->createReflectionProvider(), __DIR__ . '/entity-manager.php', null),
 			new DescriptorRegistry([
 				new BigIntType(),
 				new StringType(),

tests/Rules/Doctrine/ORM/EntityRelationRuleTest.php

@@ -16,7 +16,7 @@ class EntityRelationRuleTest extends RuleTestCase
 	protected function getRule(): Rule
 	{
 		return new EntityRelationRule(
-			new ObjectMetadataResolver(__DIR__ . '/entity-manager.php', null)
+			new ObjectMetadataResolver($this->createReflectionProvider(), __DIR__ . '/entity-manager.php', null)
 		);
 	}
 

tests/Rules/Doctrine/ORM/QueryBuilderDqlRuleTest.php

@@ -30,7 +30,7 @@ class QueryBuilderDqlRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new QueryBuilderDqlRule(new ObjectMetadataResolver(__DIR__ . '/entity-manager.php', null), true);
+		return new QueryBuilderDqlRule(new ObjectMetadataResolver($this->createReflectionProvider(), __DIR__ . '/entity-manager.php', null), true);
 	}
 
 	public function testRule(): void
@@ -168,7 +168,7 @@ public function testBranchingPerformance(): void
 	 */
 	public function getDynamicMethodReturnTypeExtensions(): array
 	{
-		$objectMetadataResolver = new ObjectMetadataResolver(__DIR__ . '/entity-manager.php', null);
+		$objectMetadataResolver = new ObjectMetadataResolver($this->createReflectionProvider(), __DIR__ . '/entity-manager.php', null);
 		$argumentsProcessor = new ArgumentsProcessor();
 
 		return [

tests/Rules/Doctrine/ORM/RepositoryMethodCallRuleTest.php

@@ -14,7 +14,7 @@ class RepositoryMethodCallRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new RepositoryMethodCallRule(new ObjectMetadataResolver(__DIR__ . '/entity-manager.php', null));
+		return new RepositoryMethodCallRule(new ObjectMetadataResolver($this->createReflectionProvider(), __DIR__ . '/entity-manager.php', null));
 	}
 
 	/**