diff --git a/CHANGELOG.md b/CHANGELOG.md index a03dc1a8..a6983a77 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,8 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D ### Fixed - [#454](https://github.com/plotly/dash-ag-grid/pull/454) fixes issue where a rowCount of 0 would cause the grid not to display new data -- [#417](https://github.com/plotly/dash-ag-grid/issues/417) fix grid rendering when `getRowId` is explicitly set to `None` +- [#459](https://github.com/plotly/dash-ag-grid/pull/459) removes `getRowsRequest` / `getRowsResponse` warnings by excluding these Dash callback props from AG Grid options. +- [#460](https://github.com/plotly/dash-ag-grid/pull/460) fix grid rendering when `getRowId` is explicitly set to `None` ## [35.2.0] - 2026-04-03 ### Added diff --git a/src/lib/utils/propCategories.js b/src/lib/utils/propCategories.js index 7528c2a2..b4de10a8 100644 --- a/src/lib/utils/propCategories.js +++ b/src/lib/utils/propCategories.js @@ -351,8 +351,8 @@ export const PROPS_NOT_FOR_AG_GRID = [ 'cellValueChanged', 'cellClicked', 'cellDoubleClicked', - 'getRowRequest', - 'getRowResponse', + 'getRowsRequest', + 'getRowsResponse', 'getDetailRequest', 'getDetailResponse', 'dangerously_allow_code', @@ -383,7 +383,7 @@ export const OMIT_PROP_RENDER = [ 'virtualRowData', 'columnState', 'filterModel', - 'getRowRequest', + 'getRowsRequest', 'getDetailRequest', 'cellValueChanged', 'cellClicked', diff --git a/tests/test_infinite_scroll.py b/tests/test_infinite_scroll.py index 6294c104..bfed0fea 100644 --- a/tests/test_infinite_scroll.py +++ b/tests/test_infinite_scroll.py @@ -247,7 +247,13 @@ def scroll(n): for x in range(8): dash_duo.find_element("#scroll").click() time.sleep(3) # pausing to emulate separation because user inputs - assert list(filter(lambda i: i.get("level") != "WARNING", dash_duo.get_logs())) == [] + logs = dash_duo.get_logs() + assert list(filter(lambda i: i.get("level") != "WARNING", logs)) == [] + assert not any( + "invalid gridOptions property 'getRowsRequest'" in log.get("message", "") + or "invalid gridOptions property 'getRowsResponse'" in log.get("message", "") + for log in logs + ) def test_is003_infinite_scroll_clear(dash_duo): app = Dash(__name__) @@ -330,4 +336,4 @@ def update_rfq_grid_rows( ) dash_duo.find_element("#reset").click() grid_dom.wait_for_cell_text(0, 0, "0") - assert x == len(test_data) # make sure the callback was called the expected number of times \ No newline at end of file + assert x == len(test_data) # make sure the callback was called the expected number of times