From 6dfe43f6fe9cf330e513be9ddbc40095b8e9c7df Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 24 Apr 2026 11:31:38 +0000 Subject: [PATCH 1/3] Initial plan From 109d3e8dfe6c440b68cad0ff13f7b1e9aa05a27d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 24 Apr 2026 11:42:29 +0000 Subject: [PATCH 2/3] Fix getRowId null handling and add regression test Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/d3df0775-0da8-4312-a469-17c0e2906cc5 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com> --- CHANGELOG.md | 1 + src/lib/fragments/AgGrid.react.js | 3 +++ tests/test_get_row_id.py | 19 +++++++++++++++++++ 3 files changed, 23 insertions(+) create mode 100644 tests/test_get_row_id.py diff --git a/CHANGELOG.md b/CHANGELOG.md index a4bb9f02..a03dc1a8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D ### Fixed - [#454](https://github.com/plotly/dash-ag-grid/pull/454) fixes issue where a rowCount of 0 would cause the grid not to display new data +- [#417](https://github.com/plotly/dash-ag-grid/issues/417) fix grid rendering when `getRowId` is explicitly set to `None` ## [35.2.0] - 2026-04-03 ### Added diff --git a/src/lib/fragments/AgGrid.react.js b/src/lib/fragments/AgGrid.react.js index dd5ed434..0ca51e81 100644 --- a/src/lib/fragments/AgGrid.react.js +++ b/src/lib/fragments/AgGrid.react.js @@ -1587,6 +1587,9 @@ export function DashAgGrid(props) { const convertedProps = convertAllProps( omit(NO_CONVERT_PROPS, {...dashGridOptions, ...restProps}) ); + if (convertedProps.getRowId === null) { + delete convertedProps.getRowId; + } if ('theme' in convertedProps) { if (typeof convertedProps.theme === 'function') { diff --git a/tests/test_get_row_id.py b/tests/test_get_row_id.py new file mode 100644 index 00000000..e3394aed --- /dev/null +++ b/tests/test_get_row_id.py @@ -0,0 +1,19 @@ +import dash_ag_grid as dag +from dash import Dash +from . import utils + + +def test_gri001_get_row_id_none_renders(dash_duo): + app = Dash(__name__) + app.layout = [ + dag.AgGrid( + id="grid", + rowData=[{"test": 1}], + columnDefs=[{"field": "test"}], + getRowId=None, + ) + ] + + dash_duo.start_server(app) + grid = utils.Grid(dash_duo, "grid") + grid.wait_for_cell_text(0, 0, "1") From 9bcb32b339fe3c2fbfab54233ed864736a4d1011 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 24 Apr 2026 11:44:05 +0000 Subject: [PATCH 3/3] Rename getRowId regression test for clarity Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/d3df0775-0da8-4312-a469-17c0e2906cc5 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com> --- tests/test_get_row_id.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_get_row_id.py b/tests/test_get_row_id.py index e3394aed..882caf39 100644 --- a/tests/test_get_row_id.py +++ b/tests/test_get_row_id.py @@ -3,7 +3,7 @@ from . import utils -def test_gri001_get_row_id_none_renders(dash_duo): +def test_get_row_id_none_renders(dash_duo): app = Dash(__name__) app.layout = [ dag.AgGrid(