add some tooltip tests; excepting handling for tooltip formatting

Author: cpsievert

R/ggplotly.R

@@ -225,7 +225,10 @@ gg2list <- function(p, width = NULL, height = NULL, tooltip = "all", source = "A
       # text aestheic should be taken verbatim (for custom tooltips)
       prefix <- if (identical(aesName, "text")) "" else paste0(varName, ": ")
       # look for the domain, if that's not found, provide the range (useful for identity scales)
-      suffix <- forMat(x[[paste0(aesName, "_plotlyDomain")]] %||% x[[aesName]])
+      suffix <- tryCatch(
+        forMat(x[[paste0(aesName, "_plotlyDomain")]] %||% x[[aesName]]),
+        error = function(e) ""
+      )
       x$hovertext <- paste0(x$hovertext, prefix, suffix)
     }
     x

tests/testthat/test-ggplot-density.R

@@ -72,12 +72,3 @@ test_that("traces are ordered correctly in geom_density", {
   expect_identical(nms, c("4", "6", "8"))
 })
 
-test_that("tooltip argument respects ordering", {
-  p <- qplot(mpg, fill = factor(cyl), data = mtcars, geom = "density")
-  p <- ggplotly(p, tooltip = c("y", "x"))
-  info <- expect_traces(p, 3, "tooltip-order")
-  txt <- strsplit(info$data[[1]]$text, "<br>")
-  expect_true(all(grepl("^density", sapply(txt, "[[", 1))))
-  expect_true(all(grepl("^mpg", sapply(txt, "[[", 2))))
-})
-

tests/testthat/test-ggplot-tooltip.R

@@ -0,0 +1,45 @@
+context("tooltip")
+
+test <- data.frame(
+  time = strptime("2016-03-12 16:32:56", format = "%Y-%m-%d %X") + 60 * 1:100, 
+  x = cos(1:100)
+)
+p <- ggplot(test, aes(time, x)) + geom_point()
+
+test_that("datetimes are displayed in tooltip properly", {
+  l <- save_outputs(p, "tooltip-datetime")
+  txt <- strsplit(l$data[[1]]$text, "<br>")
+  expect_identical(
+    paste0("time: ", test$time), sapply(txt, "[[", 1)
+  )
+})
+
+test <- data.frame(
+  time = strptime("2016-03-12", format = "%Y-%m-%d") + 1:100, 
+  x = sin(1:100)
+)
+p <- ggplot(test, aes(time, x)) + geom_point()
+
+test_that("dates are displayed in tooltip properly", {
+  l <- save_outputs(p, "tooltip-date")
+  txt <- strsplit(l$data[[1]]$text, "<br>")
+  expect_identical(
+    paste0("time: ", test$time), sapply(txt, "[[", 1)
+  )
+})
+
+test_that("tooltip argument respects ordering", {
+  p <- qplot(mpg, fill = factor(cyl), data = mtcars, geom = "density")
+  p <- ggplotly(p, tooltip = c("y", "x"))
+  info <- plotly_build(p)
+  txt <- strsplit(info$data[[1]]$text, "<br>")
+  expect_true(all(grepl("^density", sapply(txt, "[[", 1))))
+  expect_true(all(grepl("^mpg", sapply(txt, "[[", 2))))
+})
+
+test_that("can hide x values in tooltip", {
+  gg2 <- ggplot(mtcars, aes(factor(cyl), mpg, fill = factor(cyl))) + geom_violin()
+  p <- ggplotly(gg2, tooltip = "y")
+  l <- plotly_build(p)
+  expect_equal(sum(grepl("cyl", l$data[[1]]$text)), 0)
+})

tests/testthat/test-ggplot-violin.R

@@ -23,10 +23,4 @@ test_that("geom_violin with fill aes works", {
   expect_equal(sum(unlist(lapply(L$data, "[[", "showlegend"))), 3)
 })
 
-test_that("can hide x values in tooltip", {
-  p <- ggplotly(gg2, tooltip = "y")
-  l <- plotly_build(p)
-  expect_equal(sum(grepl("cyl", l$data[[1]]$text)), 0)
-})
-