Allow multiple bars for a given x (this is nice for mapping text, in particular)

Author: cpsievert

R/layers2traces.R

@@ -410,19 +410,7 @@ geom2trace.GeomPoint <- function(data, params) {
 
 #' @export
 geom2trace.GeomBar <- function(data, params) {
-  if (!anyDuplicated(data[c("x", "PANEL", "group")])) {
-    # assuming `layout.barmode='stack'`
-    data$y <- data$ymax - data$ymin
-  } else {
-    # if there is more than one y-value for a particular combination of
-    # x, PANEL, and group; then take the _max_ y.
-    data <- plyr::ddply(
-      data, c("x", "PANEL", "group"),
-      plyr::summarise, 
-      y = max(y)
-    )
-    data <- prefix_class(data, "GeomBar") 
-  }
+  data$y <- data$ymax - data$ymin
   # TODO: use xmin/xmax once plotly.js allows explicit bar widths
   # https://github.com/plotly/plotly.js/issues/80
   list(

man/group2NA.Rd

@@ -138,13 +138,8 @@ test_that("geom_bar(position = 'fill') stacks proportions", {
 d <- head(diamonds, 50)
 gbar <- ggplot(d, aes(cut, price)) + geom_bar(stat = "identity")
 
-test_that("For a given x value, if multiple y exist, sum them. ", {
+test_that("Using identity with multiple y for a given x works ", {
   info <- expect_traces(gbar, 1, "category-names")
-  expect_identical(info$data[[1]]$type, "bar")
-  y <- with(d, tapply(price, cut, sum))
-  # make sure order of counts match
-  y <- y[info$data[[1]]$x]
-  expect_equal(info$data[[1]]$y, as.numeric(y))
 })
 
 p <- ggplot(mtcars, aes(factor(cyl))) + geom_bar() + coord_flip()