fix #1782 (second half: arrowheads broken) - 🔪 parentElement

this must have been broken since day 1, oddly enough...

Author: alexcjohnson

src/components/annotations/draw_arrow_head.js

@@ -111,7 +111,7 @@ module.exports = function drawArrowHead(el3, style, ends, mag, standoff) {
     function drawhead(p, rot) {
         if(!headStyle.path) return;
         if(style > 5) rot = 0; // don't rotate square or circle
-        d3.select(el.parentElement).append('path')
+        d3.select(el.parentNode).append('path')
             .attr({
                 'class': el3.attr('class'),
                 d: headStyle.path,

src/traces/sankey/render.js

@@ -220,7 +220,7 @@ function nodeModel(uniqueKeys, d, n) {
 // rendering snippets
 
 function crispLinesOnEnd(sankeyNode) {
-    d3.select(sankeyNode.node().parentElement).style('shape-rendering', 'crispEdges');
+    d3.select(sankeyNode.node().parentNode).style('shape-rendering', 'crispEdges');
 }
 
 function updateNodePositions(sankeyNode) {
@@ -239,7 +239,7 @@ function linkPath(d) {
 }
 
 function updateNodeShapes(sankeyNode) {
-    d3.select(sankeyNode.node().parentElement).style('shape-rendering', 'optimizeSpeed');
+    d3.select(sankeyNode.node().parentNode).style('shape-rendering', 'optimizeSpeed');
     sankeyNode.call(updateNodePositions);
 }
 

tasks/test_syntax.js

@@ -77,6 +77,9 @@ function assertSrcContents() {
                     else if(lastPart === 'innerHTML') {
                         logs.push(file + ' : contains .innerHTML (IE failure in SVG)');
                     }
+                    else if(lastPart === 'parentElement') {
+                        logs.push(file + ' : contains .parentElement (IE failure)');
+                    }
                     else if(node.source() === 'Math.sign') {
                         logs.push(file + ' : contains Math.sign (IE failure)');
                     }