move legend defaults to own module

Author: etpinard

src/components/legend/defaults.js

@@ -0,0 +1,70 @@
+/**
+* Copyright 2012-2016, Plotly, Inc.
+* All rights reserved.
+*
+* This source code is licensed under the MIT license found in the
+* LICENSE file in the root directory of this source tree.
+*/
+
+
+'use strict';
+
+var Lib = require('../../lib');
+var Plots = require('../../plots/plots');
+
+var attributes = require('./attributes');
+var helpers = require('./helpers');
+
+
+module.exports = function legendDefaults(layoutIn, layoutOut, fullData) {
+    var containerIn = layoutIn.legend || {},
+        containerOut = layoutOut.legend = {};
+
+    var visibleTraces = 0,
+        defaultOrder = 'normal',
+        trace;
+
+    for(var i = 0; i < fullData.length; i++) {
+        trace = fullData[i];
+
+        if(helpers.legendGetsTrace(trace)) {
+            visibleTraces++;
+            // always show the legend by default if there's a pie
+            if(Plots.traceIs(trace, 'pie')) visibleTraces++;
+        }
+
+        if((Plots.traceIs(trace, 'bar') && layoutOut.barmode==='stack') ||
+                ['tonextx','tonexty'].indexOf(trace.fill)!==-1) {
+            defaultOrder = helpers.isGrouped({traceorder: defaultOrder}) ?
+                'grouped+reversed' : 'reversed';
+        }
+
+        if(trace.legendgroup !== undefined && trace.legendgroup !== '') {
+            defaultOrder = helpers.isReversed({traceorder: defaultOrder}) ?
+                'reversed+grouped' : 'grouped';
+        }
+    }
+
+    function coerce(attr, dflt) {
+        return Lib.coerce(containerIn, containerOut, attributes, attr, dflt);
+    }
+
+    var showLegend = Lib.coerce(layoutIn, layoutOut,
+        Plots.layoutAttributes, 'showlegend', visibleTraces > 1);
+
+    if(showLegend === false) return;
+
+    coerce('bgcolor', layoutOut.paper_bgcolor);
+    coerce('bordercolor');
+    coerce('borderwidth');
+    Lib.coerceFont(coerce, 'font', layoutOut.font);
+
+    coerce('traceorder', defaultOrder);
+    if(helpers.isGrouped(layoutOut.legend)) coerce('tracegroupgap');
+
+    coerce('x');
+    coerce('xanchor');
+    coerce('y');
+    coerce('yanchor');
+    Lib.noneOrAll(containerIn, containerOut, ['x', 'y']);
+};

src/components/legend/index.js

@@ -28,60 +28,7 @@ var legend = module.exports = {};
 var constants = require('./constants');
 legend.layoutAttributes = require('./attributes');
 
-legend.supplyLayoutDefaults = function(layoutIn, layoutOut, fullData) {
-    var containerIn = layoutIn.legend || {},
-        containerOut = layoutOut.legend = {};
-
-    var visibleTraces = 0,
-        defaultOrder = 'normal',
-        trace;
-
-    for(var i = 0; i < fullData.length; i++) {
-        trace = fullData[i];
-
-        if(legendGetsTrace(trace)) {
-            visibleTraces++;
-            // always show the legend by default if there's a pie
-            if(Plots.traceIs(trace, 'pie')) visibleTraces++;
-        }
-
-        if((Plots.traceIs(trace, 'bar') && layoutOut.barmode==='stack') ||
-                ['tonextx','tonexty'].indexOf(trace.fill)!==-1) {
-            defaultOrder = isGrouped({traceorder: defaultOrder}) ?
-                'grouped+reversed' : 'reversed';
-        }
-
-        if(trace.legendgroup !== undefined && trace.legendgroup !== '') {
-            defaultOrder = isReversed({traceorder: defaultOrder}) ?
-                'reversed+grouped' : 'grouped';
-        }
-    }
-
-    function coerce(attr, dflt) {
-        return Lib.coerce(containerIn, containerOut,
-            legend.layoutAttributes, attr, dflt);
-    }
-
-    var showLegend = Lib.coerce(layoutIn, layoutOut,
-        Plots.layoutAttributes, 'showlegend', visibleTraces > 1);
-
-    if(showLegend === false) return;
-
-    coerce('bgcolor', layoutOut.paper_bgcolor);
-    coerce('bordercolor');
-    coerce('borderwidth');
-    Lib.coerceFont(coerce, 'font', layoutOut.font);
-
-    coerce('traceorder', defaultOrder);
-    if(isGrouped(layoutOut.legend)) coerce('tracegroupgap');
-
-    coerce('x');
-    coerce('xanchor');
-    coerce('y');
-    coerce('yanchor');
-    Lib.noneOrAll(containerIn, containerOut, ['x', 'y']);
-};
-
+legend.supplyLayoutDefaults = require('./defaults');
 // -----------------------------------------------------
 // styling functions for traces in legends.
 // same functions for styling traces in the popovers