Commit a926577
committed
fix create_hexbin_map truncating aggregated values to integers
The aggregated "color" column was cast to Int64, so any non-integer
result of agg_func (e.g. the mean of a column with values between 0
and 1) got truncated and np.min/np.mean/np.max all produced the same
map. The cast came in with the narwhals port; before that the column
went through pd.to_numeric and kept its float values. Drop the cast.
Closes #46321 parent 05579b0 commit a926577
3 files changed
Lines changed: 27 additions & 3 deletions
File tree
- plotly/figure_factory
- tests/test_optional/test_figure_factory
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
440 | | - | |
441 | | - | |
442 | | - | |
| 440 | + | |
443 | 441 | | |
444 | 442 | | |
445 | 443 | | |
| |||
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1275 | 1275 | | |
1276 | 1276 | | |
1277 | 1277 | | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
| 1286 | + | |
| 1287 | + | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
1278 | 1302 | | |
1279 | 1303 | | |
1280 | 1304 | | |
| |||
0 commit comments