Remove punycode fallback for Electron v3

Author: codenirvana

CHANGELOG.yaml

@@ -1,3 +1,7 @@
+unreleased:
+  chores:
+    - Removed punycode fallback for Electron v3
+
 3.0.3:
   date: 2021-07-25
   fixed bugs:

encoder/index.js

@@ -44,7 +44,7 @@
  * @see {@link https://tools.ietf.org/html/rfc3986#section-3}
  */
 
-const url = require('url'),
+const domainToASCII = require('url').domainToASCII,
 
     encodeSet = require('./encode-set'),
 
@@ -69,38 +69,7 @@ const url = require('url'),
     OBJECT = 'object',
 
     PATH_SEPARATOR = '/',
-    DOMAIN_SEPARATOR = '.',
-
-    /**
-     * Returns the Punycode ASCII serialization of the domain.
-     *
-     * @note `url.domainToASCII` returns empty string for invalid domain.
-     *
-     * @todo Remove `punycode` dependency on Node version >= 6.13.0.
-     *  For backward compatibility, fallback to `punycode` as url.domainToASCII.
-     *
-     * @private
-     * @function
-     * @param {String} domain domain name
-     * @returns {String} punycode encoded domain name
-     */
-    domainToASCII = (function () {
-        const domainToASCII = url.domainToASCII;
-
-        // @note In Electron v3.1.8, the Node.js native url.domainToASCII
-        // doesn't work as expected. ¯\_(ツ)_/¯
-        // so, check if it convert's '😎' to 'xn--s28h' or not.
-        // @todo Remove this hack on Electron >= 4
-        /* istanbul ignore next */
-        if (typeof domainToASCII === 'function' && domainToASCII('😎') === 'xn--s28h') {
-            // use faster native method
-            return domainToASCII;
-        }
-
-        // else, lazy load `punycode` dependency
-        /* istanbul ignore next */
-        return require('punycode').toASCII;
-    }());
+    DOMAIN_SEPARATOR = '.';
 
 /**
  * Returns the Punycode ASCII serialization of the domain.

package-lock.json

@@ -30,9 +30,6 @@
     "test-system": "node npm/test-system.js",
     "test-unit": "nyc --nycrc-path=.nycrc.js node npm/test-unit.js"
   },
-  "dependencies": {
-    "punycode": "^2.1.1"
-  },
   "devDependencies": {
     "@postman/csv-parse": "^4.0.2",
     "@postman/shipit": "^0.3.0",