Skip to content

Commit 1127755

Browse files
committed
MenubarSubmenu: update to named export, no-verify for remaining ts errors
1 parent d8327b5 commit 1127755

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

client/components/Menubar/Menubar.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React from 'react';
22
import { render, screen, fireEvent } from '../../test-utils';
33
import { Menubar } from './Menubar';
4-
import MenubarSubmenu from './MenubarSubmenu';
4+
import { MenubarSubmenu } from './MenubarSubmenu';
55
import { MenubarItem } from './MenubarItem';
66

77
describe('Menubar', () => {

client/components/Menubar/MenubarSubmenu.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ export interface MenubarSubmenuProps {
234234
listRole?: MenubarListItemRole;
235235
}
236236

237-
function MenubarSubmenu({
237+
export function MenubarSubmenu({
238238
children,
239239
id,
240240
title,
@@ -457,5 +457,3 @@ function MenubarSubmenu({
457457
</SubmenuContext.Provider>
458458
);
459459
}
460-
461-
export default MenubarSubmenu;

client/modules/IDE/components/Header/Nav.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { sortBy } from 'lodash';
44
import { Link } from 'react-router-dom';
55
import PropTypes from 'prop-types';
66
import { useTranslation } from 'react-i18next';
7-
import MenubarSubmenu from '../../../../components/Menubar/MenubarSubmenu';
7+
import { MenubarSubmenu } from '../../../../components/Menubar/MenubarSubmenu';
88
import { MenubarItem } from '../../../../components/Menubar/MenubarItem';
99
import { availableLanguages, languageKeyToLabel } from '../../../../i18n';
1010
import { getConfig } from '../../../../utils/getConfig';

client/modules/IDE/components/Header/Nav.unit.test.jsx

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,25 @@ jest.mock('../../../../components/Menubar/Menubar', () => ({
1717

1818
// mock MenubarSubmenu
1919
jest.mock('../../../../components/Menubar/MenubarSubmenu', () => {
20-
function MenubarSubmenu({ children, title }) {
21-
return (
22-
<li className="nav__item">
23-
<span role="menuitem">{title}</span>
24-
<ul role="menu" aria-label={`${title} menu`}>
25-
{children}
26-
</ul>
27-
</li>
28-
);
29-
}
20+
const MenubarSubmenu = ({ children, title }) => (
21+
<li className="nav__item">
22+
<span role="menuitem">{title}</span>
23+
<ul role="menu" aria-label={`${title} menu`}>
24+
{children}
25+
</ul>
26+
</li>
27+
);
3028

31-
MenubarSubmenu.useMenuProps = () => ({
29+
const useMenuProps = () => ({
3230
isOpen: false,
3331
handlers: {}
3432
});
3533

36-
return MenubarSubmenu;
34+
return {
35+
__esModule: true,
36+
MenubarSubmenu,
37+
useMenuProps
38+
};
3739
});
3840

3941
// mock MenubarItem

0 commit comments

Comments
 (0)