From 9a749c5ce283e1e394f415ef0d1d734aa9c784f7 Mon Sep 17 00:00:00 2001 From: Luke Videckis Date: Wed, 25 Jun 2025 15:18:19 -0600 Subject: [PATCH 1/3] rename --- .github/workflows/programming_team_code_ci.yml | 6 +++--- tests/Makefile | 6 +++--- tests/scripts/{ptc.sh => build_pdf.sh} | 0 3 files changed, 6 insertions(+), 6 deletions(-) rename tests/scripts/{ptc.sh => build_pdf.sh} (100%) diff --git a/.github/workflows/programming_team_code_ci.yml b/.github/workflows/programming_team_code_ci.yml index 89422aa9..3b730355 100644 --- a/.github/workflows/programming_team_code_ci.yml +++ b/.github/workflows/programming_team_code_ci.yml @@ -82,7 +82,7 @@ jobs: - name: files without tests run: make --directory=tests/ files_without_tests - build_ptc: + build_pdf: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -93,7 +93,7 @@ jobs: wget -qO- https://apt.llvm.org/llvm.sh | sudo bash -s -- 19 sudo apt update && sudo apt install -y clang-19 - name: build ptc - run: make --directory=tests/ ptc + run: make --directory=tests/ build_pdf - uses: actions/upload-artifact@v4 with: name: ptc @@ -101,7 +101,7 @@ jobs: publish_ptc: runs-on: ubuntu-latest - needs: [library_checker_aizu, grep_clangformat_cppcheck, clangtidy, compile_gcc, compile_clang, files_without_tests, build_ptc] + needs: [library_checker_aizu, grep_clangformat_cppcheck, clangtidy, compile_gcc, compile_clang, files_without_tests, build_pdf] if: github.ref == 'refs/heads/dev' && github.event_name == 'push' steps: - uses: actions/checkout@v2 diff --git a/tests/Makefile b/tests/Makefile index dc467340..374af315 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -13,7 +13,7 @@ help: @echo " |" @echo "make clangtidy | runs clang-tidy (mainly to verify snake_case)" @echo " |" - @echo "make ptc | build ptc.pdf from .tex file" + @echo "make build_pdf | build build_pdf.pdf from .tex file" @echo " |" @echo "make shellcheck_shfmt | runs shellcheck and shfmt" @echo " |" @@ -43,8 +43,8 @@ clangtidy: files_without_tests: ./scripts/files_without_tests.sh -ptc: - ./scripts/ptc.sh +build_pdf: + ./scripts/build_pdf.sh shellcheck_shfmt: ./scripts/shellcheck_shfmt.sh diff --git a/tests/scripts/ptc.sh b/tests/scripts/build_pdf.sh similarity index 100% rename from tests/scripts/ptc.sh rename to tests/scripts/build_pdf.sh From 8567c94d397c9ffffdf02ff25aeeb5de346d3760 Mon Sep 17 00:00:00 2001 From: Luke Videckis Date: Wed, 25 Jun 2025 15:21:39 -0600 Subject: [PATCH 2/3] another rename --- .github/workflows/programming_team_code_ci.yml | 8 ++++---- tests/Makefile | 6 +++--- ...files_without_tests.sh => find_files_without_tests.sh} | 0 3 files changed, 7 insertions(+), 7 deletions(-) rename tests/scripts/{files_without_tests.sh => find_files_without_tests.sh} (100%) diff --git a/.github/workflows/programming_team_code_ci.yml b/.github/workflows/programming_team_code_ci.yml index 3b730355..2b816678 100644 --- a/.github/workflows/programming_team_code_ci.yml +++ b/.github/workflows/programming_team_code_ci.yml @@ -75,12 +75,12 @@ jobs: - name: Compile all tests run: make --directory=tests/ compile_clang - files_without_tests: + find_files_without_tests: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: files without tests - run: make --directory=tests/ files_without_tests + run: make --directory=tests/ find_files_without_tests build_pdf: runs-on: ubuntu-latest @@ -101,7 +101,7 @@ jobs: publish_ptc: runs-on: ubuntu-latest - needs: [library_checker_aizu, grep_clangformat_cppcheck, clangtidy, compile_gcc, compile_clang, files_without_tests, build_pdf] + needs: [library_checker_aizu, grep_clangformat_cppcheck, clangtidy, compile_gcc, compile_clang, find_files_without_tests, build_pdf] if: github.ref == 'refs/heads/dev' && github.event_name == 'push' steps: - uses: actions/checkout@v2 @@ -119,7 +119,7 @@ jobs: update_main: runs-on: ubuntu-latest - needs: [library_checker_aizu, grep_clangformat_cppcheck, clangtidy, compile_gcc, compile_clang, files_without_tests] + needs: [library_checker_aizu, grep_clangformat_cppcheck, clangtidy, compile_gcc, compile_clang, find_files_without_tests] if: github.ref == 'refs/heads/dev' && github.event_name == 'push' steps: - uses: actions/checkout@v2 diff --git a/tests/Makefile b/tests/Makefile index 374af315..0e663fd5 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -20,7 +20,7 @@ help: @echo "make update_main | 1) copies included files into file" @echo " | 2) force pushes to main branch" @echo " |" - @echo "make files_without_tests | print list of all .hpp files included by *no* .test.cpp files" + @echo "make find_files_without_tests | print list of all .hpp files included by *no* .test.cpp files" @echo " | - these files are not compiled nor linted as part of ci" @echo " |" @echo "make print_which_tests_havent_run | mainly to check if all tests have run" @@ -40,8 +40,8 @@ do_format: clangtidy: ./scripts/clangtidy.sh -files_without_tests: - ./scripts/files_without_tests.sh +find_files_without_tests: + ./scripts/find_files_without_tests.sh build_pdf: ./scripts/build_pdf.sh diff --git a/tests/scripts/files_without_tests.sh b/tests/scripts/find_files_without_tests.sh similarity index 100% rename from tests/scripts/files_without_tests.sh rename to tests/scripts/find_files_without_tests.sh From 9d4678415b71d2e2f57b89e386b89819f96d9867 Mon Sep 17 00:00:00 2001 From: Luke Videckis Date: Wed, 25 Jun 2025 15:24:46 -0600 Subject: [PATCH 3/3] rename --- .github/workflows/programming_team_code_ci.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/programming_team_code_ci.yml b/.github/workflows/programming_team_code_ci.yml index 2b816678..35687504 100644 --- a/.github/workflows/programming_team_code_ci.yml +++ b/.github/workflows/programming_team_code_ci.yml @@ -24,7 +24,7 @@ jobs: git submodule init git submodule update rm -rf hackpack-cpp/tests/ - - name: Run tests + - name: Run library checker and aizu tests env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: oj-verify all --tle 60 --timeout 21600 @@ -40,7 +40,7 @@ jobs: wget -O - https://apt.llvm.org/llvm.sh | sudo bash - name: Install dependencies run: sudo apt update && sudo apt install -y clang-format-19 cppcheck - - name: checks format then lints + - name: grep, clang-format, cppcheck run: make --directory=tests/ grep_clangformat_cppcheck clangtidy: @@ -61,7 +61,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: Compile all tests + - name: g++ with gcc run: make --directory=tests/ compile_gcc compile_clang: @@ -72,14 +72,14 @@ jobs: run: wget -qO- https://apt.llvm.org/llvm.sh | sudo bash -s -- 19 - name: Install dependencies run: sudo apt update && sudo apt install -y clang-19 - - name: Compile all tests + - name: g++ with clang run: make --directory=tests/ compile_clang find_files_without_tests: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: files without tests + - name: find files without tests run: make --directory=tests/ find_files_without_tests build_pdf: @@ -92,7 +92,7 @@ jobs: sudo apt install texlive texlive-latex-extra rename nodejs npm wget -qO- https://apt.llvm.org/llvm.sh | sudo bash -s -- 19 sudo apt update && sudo apt install -y clang-19 - - name: build ptc + - name: build pdf run: make --directory=tests/ build_pdf - uses: actions/upload-artifact@v4 with: @@ -147,5 +147,5 @@ jobs: - uses: actions/checkout@v2 - name: Install dependencies run: sudo apt install shfmt shellcheck - - name: shellcheck and shfmt + - name: shellcheck, shfmt run: make --directory=tests/ shellcheck_shfmt