From 0483e0334dad19dada31fc3cf4d448c6aac0dd8a Mon Sep 17 00:00:00 2001 From: Kai Blaschke Date: Fri, 10 Oct 2025 14:36:44 +0200 Subject: [PATCH 1/7] Fix includes and some comments --- src/libprojectM/Audio/CMakeLists.txt | 2 +- src/libprojectM/Audio/FrameAudioData.hpp | 5 +++-- src/libprojectM/Audio/Loudness.cpp | 2 +- src/libprojectM/Audio/Loudness.hpp | 2 +- src/libprojectM/Audio/MilkdropFFT.cpp | 2 +- src/libprojectM/Audio/PCM.cpp | 2 +- src/libprojectM/Audio/PCM.hpp | 10 +++++----- src/libprojectM/Audio/WaveformAligner.cpp | 2 +- src/libprojectM/Audio/WaveformAligner.hpp | 2 +- src/libprojectM/MilkdropPreset/BlurTexture.hpp | 4 +--- src/libprojectM/MilkdropPreset/Border.cpp | 2 ++ src/libprojectM/MilkdropPreset/Border.hpp | 1 - .../MilkdropPreset/CustomWaveform.hpp | 2 +- .../MilkdropPreset/MilkdropPreset.hpp | 3 --- .../MilkdropPreset/MilkdropShader.cpp | 1 - .../MilkdropPreset/MilkdropShader.hpp | 2 +- .../MilkdropPreset/PerPixelContext.cpp | 1 + .../MilkdropPreset/PerPixelContext.hpp | 2 +- src/libprojectM/MilkdropPreset/PerPixelMesh.hpp | 3 +-- src/libprojectM/MilkdropPreset/PresetState.cpp | 2 +- .../MilkdropPreset/ShapePerFrameContext.cpp | 1 - src/libprojectM/MilkdropPreset/Waveform.hpp | 1 - .../MilkdropPreset/Waveforms/CenteredSpiro.cpp | 2 +- .../MilkdropPreset/Waveforms/DerivativeLine.cpp | 2 +- .../MilkdropPreset/Waveforms/DoubleLine.cpp | 2 +- .../MilkdropPreset/Waveforms/ExplosiveHash.cpp | 2 +- .../MilkdropPreset/Waveforms/Factory.hpp | 2 +- .../MilkdropPreset/Waveforms/Line.cpp | 2 +- .../MilkdropPreset/Waveforms/LineBase.cpp | 2 +- .../MilkdropPreset/Waveforms/SpectrumLine.cpp | 2 +- src/libprojectM/PresetFactoryManager.cpp | 4 ++-- src/libprojectM/ProjectM.hpp | 1 - src/libprojectM/ProjectMCWrapper.cpp | 4 ++-- src/libprojectM/Renderer/CopyTexture.cpp | 2 +- src/libprojectM/Renderer/Framebuffer.cpp | 2 +- src/libprojectM/Renderer/Mesh.cpp | 2 +- src/libprojectM/Renderer/Mesh.hpp | 16 +++++++--------- src/libprojectM/Renderer/MilkdropNoise.cpp | 2 +- src/libprojectM/Renderer/PresetTransition.cpp | 6 ++---- src/libprojectM/Renderer/TextureAttachment.cpp | 2 +- src/libprojectM/Renderer/TextureManager.cpp | 13 +++++++------ .../Renderer/TextureSamplerDescriptor.cpp | 4 ++-- .../Renderer/TransitionShaderManager.cpp | 4 +--- src/libprojectM/Renderer/VertexArray.hpp | 3 --- src/libprojectM/Renderer/VertexIndexArray.cpp | 2 +- src/libprojectM/UserSprites/MilkdropSprite.cpp | 3 ++- 46 files changed, 63 insertions(+), 77 deletions(-) diff --git a/src/libprojectM/Audio/CMakeLists.txt b/src/libprojectM/Audio/CMakeLists.txt index c5db70b07e..99685b95c4 100644 --- a/src/libprojectM/Audio/CMakeLists.txt +++ b/src/libprojectM/Audio/CMakeLists.txt @@ -14,7 +14,7 @@ add_library(Audio OBJECT target_include_directories(Audio PUBLIC - ${CMAKE_CURRENT_SOURCE_DIR} + ${CMAKE_CURRENT_SOURCE_DIR}/.. ) target_link_libraries(Audio diff --git a/src/libprojectM/Audio/FrameAudioData.hpp b/src/libprojectM/Audio/FrameAudioData.hpp index f905bb33a0..98ed4177ab 100644 --- a/src/libprojectM/Audio/FrameAudioData.hpp +++ b/src/libprojectM/Audio/FrameAudioData.hpp @@ -6,8 +6,9 @@ */ #pragma once -#include "projectM-4/projectM_export.h" -#include "AudioConstants.hpp" +#include "Audio/AudioConstants.hpp" + +#include #include diff --git a/src/libprojectM/Audio/Loudness.cpp b/src/libprojectM/Audio/Loudness.cpp index 2139c92406..0f8d6371dd 100644 --- a/src/libprojectM/Audio/Loudness.cpp +++ b/src/libprojectM/Audio/Loudness.cpp @@ -1,4 +1,4 @@ -#include "Loudness.hpp" +#include "Audio/Loudness.hpp" #include diff --git a/src/libprojectM/Audio/Loudness.hpp b/src/libprojectM/Audio/Loudness.hpp index 55f3baf8cf..7d453bd297 100644 --- a/src/libprojectM/Audio/Loudness.hpp +++ b/src/libprojectM/Audio/Loudness.hpp @@ -5,7 +5,7 @@ #pragma once -#include "AudioConstants.hpp" +#include "Audio/AudioConstants.hpp" #include #include diff --git a/src/libprojectM/Audio/MilkdropFFT.cpp b/src/libprojectM/Audio/MilkdropFFT.cpp index 83dfe128d4..134f338a17 100644 --- a/src/libprojectM/Audio/MilkdropFFT.cpp +++ b/src/libprojectM/Audio/MilkdropFFT.cpp @@ -27,7 +27,7 @@ IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISI OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "MilkdropFFT.hpp" +#include "Audio/MilkdropFFT.hpp" namespace libprojectM { namespace Audio { diff --git a/src/libprojectM/Audio/PCM.cpp b/src/libprojectM/Audio/PCM.cpp index 56a7cc65d0..bc7c83c59a 100755 --- a/src/libprojectM/Audio/PCM.cpp +++ b/src/libprojectM/Audio/PCM.cpp @@ -1,4 +1,4 @@ -#include "PCM.hpp" +#include "Audio/PCM.hpp" namespace libprojectM { namespace Audio { diff --git a/src/libprojectM/Audio/PCM.hpp b/src/libprojectM/Audio/PCM.hpp index 602e2490fb..bfda1a4235 100755 --- a/src/libprojectM/Audio/PCM.hpp +++ b/src/libprojectM/Audio/PCM.hpp @@ -7,11 +7,11 @@ #pragma once -#include "AudioConstants.hpp" -#include "FrameAudioData.hpp" -#include "Loudness.hpp" -#include "MilkdropFFT.hpp" -#include "WaveformAligner.hpp" +#include "Audio/AudioConstants.hpp" +#include "Audio/FrameAudioData.hpp" +#include "Audio/Loudness.hpp" +#include "Audio/MilkdropFFT.hpp" +#include "Audio/WaveformAligner.hpp" #include diff --git a/src/libprojectM/Audio/WaveformAligner.cpp b/src/libprojectM/Audio/WaveformAligner.cpp index 6d59f5aca0..a92eea200c 100644 --- a/src/libprojectM/Audio/WaveformAligner.cpp +++ b/src/libprojectM/Audio/WaveformAligner.cpp @@ -1,4 +1,4 @@ -#include "WaveformAligner.hpp" +#include "Audio/WaveformAligner.hpp" #include #include diff --git a/src/libprojectM/Audio/WaveformAligner.hpp b/src/libprojectM/Audio/WaveformAligner.hpp index 74b7e616a1..9c0950b4f7 100644 --- a/src/libprojectM/Audio/WaveformAligner.hpp +++ b/src/libprojectM/Audio/WaveformAligner.hpp @@ -5,7 +5,7 @@ #pragma once -#include "AudioConstants.hpp" +#include "Audio/AudioConstants.hpp" #include #include diff --git a/src/libprojectM/MilkdropPreset/BlurTexture.hpp b/src/libprojectM/MilkdropPreset/BlurTexture.hpp index 04647a5a80..bfab458fbb 100644 --- a/src/libprojectM/MilkdropPreset/BlurTexture.hpp +++ b/src/libprojectM/MilkdropPreset/BlurTexture.hpp @@ -4,10 +4,8 @@ */ #pragma once -#include "Renderer/Mesh.hpp" - - #include +#include #include #include #include diff --git a/src/libprojectM/MilkdropPreset/Border.cpp b/src/libprojectM/MilkdropPreset/Border.cpp index 10dd8c9d90..f5805e4e80 100644 --- a/src/libprojectM/MilkdropPreset/Border.cpp +++ b/src/libprojectM/MilkdropPreset/Border.cpp @@ -1,5 +1,7 @@ #include "Border.hpp" +#include "PerFrameContext.hpp" + #include namespace libprojectM { diff --git a/src/libprojectM/MilkdropPreset/Border.hpp b/src/libprojectM/MilkdropPreset/Border.hpp index b8f8f7eeb8..839398ca19 100644 --- a/src/libprojectM/MilkdropPreset/Border.hpp +++ b/src/libprojectM/MilkdropPreset/Border.hpp @@ -1,6 +1,5 @@ #pragma once -#include "PerFrameContext.hpp" #include "PresetState.hpp" #include diff --git a/src/libprojectM/MilkdropPreset/CustomWaveform.hpp b/src/libprojectM/MilkdropPreset/CustomWaveform.hpp index e82687ae91..7e16d6afce 100644 --- a/src/libprojectM/MilkdropPreset/CustomWaveform.hpp +++ b/src/libprojectM/MilkdropPreset/CustomWaveform.hpp @@ -5,7 +5,7 @@ #include #include -#include "Renderer/Point.hpp" +#include #include diff --git a/src/libprojectM/MilkdropPreset/MilkdropPreset.hpp b/src/libprojectM/MilkdropPreset/MilkdropPreset.hpp index 06fa470bb7..c1f0ab17de 100644 --- a/src/libprojectM/MilkdropPreset/MilkdropPreset.hpp +++ b/src/libprojectM/MilkdropPreset/MilkdropPreset.hpp @@ -27,7 +27,6 @@ #include "CustomShape.hpp" #include "CustomWaveform.hpp" #include "DarkenCenter.hpp" -#include "Filters.hpp" #include "FinalComposite.hpp" #include "MotionVectors.hpp" #include "PerFrameContext.hpp" @@ -39,8 +38,6 @@ #include #include -#include -#include #include #include diff --git a/src/libprojectM/MilkdropPreset/MilkdropShader.cpp b/src/libprojectM/MilkdropPreset/MilkdropShader.cpp index a19af6512b..d9e325a1df 100644 --- a/src/libprojectM/MilkdropPreset/MilkdropShader.cpp +++ b/src/libprojectM/MilkdropPreset/MilkdropShader.cpp @@ -1,6 +1,5 @@ #include "MilkdropShader.hpp" -#include "PerFrameContext.hpp" #include "PresetState.hpp" #include "Utils.hpp" diff --git a/src/libprojectM/MilkdropPreset/MilkdropShader.hpp b/src/libprojectM/MilkdropPreset/MilkdropShader.hpp index 4f8165dc7b..2997a8208c 100644 --- a/src/libprojectM/MilkdropPreset/MilkdropShader.hpp +++ b/src/libprojectM/MilkdropPreset/MilkdropShader.hpp @@ -1,5 +1,5 @@ /** - * @file MilkdropShader + * @file MilkdropShader.hpp * @brief Holds a warp or composite shader of Milkdrop presets. * * This class wraps the conversion from HLSL shader code to GLSL and also manages the diff --git a/src/libprojectM/MilkdropPreset/PerPixelContext.cpp b/src/libprojectM/MilkdropPreset/PerPixelContext.cpp index ce19ff47f4..2942a7f2fe 100644 --- a/src/libprojectM/MilkdropPreset/PerPixelContext.cpp +++ b/src/libprojectM/MilkdropPreset/PerPixelContext.cpp @@ -1,6 +1,7 @@ #include "PerPixelContext.hpp" #include "MilkdropPresetExceptions.hpp" +#include "PerFrameContext.hpp" #include diff --git a/src/libprojectM/MilkdropPreset/PerPixelContext.hpp b/src/libprojectM/MilkdropPreset/PerPixelContext.hpp index 9bd25ba1b0..e20acadb21 100644 --- a/src/libprojectM/MilkdropPreset/PerPixelContext.hpp +++ b/src/libprojectM/MilkdropPreset/PerPixelContext.hpp @@ -1,6 +1,5 @@ #pragma once -#include "PerFrameContext.hpp" #include "PresetState.hpp" #include @@ -36,6 +35,7 @@ class PerPixelContext * is an undocumented feature, we should do the same as some presets may depend on it. * * @param state The preset state container. + * @param perFrameState The per-frame execution context. */ void LoadStateReadOnlyVariables(PresetState& state, PerFrameContext& perFrameState); diff --git a/src/libprojectM/MilkdropPreset/PerPixelMesh.hpp b/src/libprojectM/MilkdropPreset/PerPixelMesh.hpp index f9a51c02b8..dda77f114b 100644 --- a/src/libprojectM/MilkdropPreset/PerPixelMesh.hpp +++ b/src/libprojectM/MilkdropPreset/PerPixelMesh.hpp @@ -1,7 +1,6 @@ #pragma once -#include "Renderer/Mesh.hpp" - +#include #include namespace libprojectM { diff --git a/src/libprojectM/MilkdropPreset/PresetState.cpp b/src/libprojectM/MilkdropPreset/PresetState.cpp index 1838269cd1..0913ac3775 100644 --- a/src/libprojectM/MilkdropPreset/PresetState.cpp +++ b/src/libprojectM/MilkdropPreset/PresetState.cpp @@ -3,7 +3,7 @@ #include "MilkdropStaticShaders.hpp" #include "PresetFileParser.hpp" -#include "Renderer/ShaderCache.hpp" +#include #include diff --git a/src/libprojectM/MilkdropPreset/ShapePerFrameContext.cpp b/src/libprojectM/MilkdropPreset/ShapePerFrameContext.cpp index 5877692f31..e31f5332db 100644 --- a/src/libprojectM/MilkdropPreset/ShapePerFrameContext.cpp +++ b/src/libprojectM/MilkdropPreset/ShapePerFrameContext.cpp @@ -2,7 +2,6 @@ #include "CustomShape.hpp" #include "MilkdropPresetExceptions.hpp" -#include "PerFrameContext.hpp" #include diff --git a/src/libprojectM/MilkdropPreset/Waveform.hpp b/src/libprojectM/MilkdropPreset/Waveform.hpp index 93d9446979..5e6084aab8 100644 --- a/src/libprojectM/MilkdropPreset/Waveform.hpp +++ b/src/libprojectM/MilkdropPreset/Waveform.hpp @@ -7,7 +7,6 @@ #include #include -#include namespace libprojectM { namespace MilkdropPreset { diff --git a/src/libprojectM/MilkdropPreset/Waveforms/CenteredSpiro.cpp b/src/libprojectM/MilkdropPreset/Waveforms/CenteredSpiro.cpp index d9ca7403c2..b7052b10ee 100644 --- a/src/libprojectM/MilkdropPreset/Waveforms/CenteredSpiro.cpp +++ b/src/libprojectM/MilkdropPreset/Waveforms/CenteredSpiro.cpp @@ -1,4 +1,4 @@ -#include "CenteredSpiro.hpp" +#include "Waveforms/CenteredSpiro.hpp" #include