Fix override graphics behaviour for renumber tool

[Wurschdhaud]

Description

• add areaplan and 3d view
• change mark element to also affect open views of selected categories, like unmark
• store the current override if any to restore during unmark. previously custom per element overrides would be reset.

---

Checklist

Before submitting your pull request, ensure the following requirements are met:

• Code follows the PEP 8 style guide.
• Code has been formatted with Black using the command:

  pipenv run black {source_file_or_directory}

• Changes are tested and verified to work as expected.

---

Related Issues

If applicable, link the issues resolved by this pull request:

• Resolves [Bug]: Parking spot renumbering changes element color only in the renumbered view (Revit 2023) #2951

---

Additional Notes

Include any additional context, screenshots, or considerations for reviewers.

---

Thank you for contributing to pyRevit! 🎉

[devloai]

PR Summary:

Fixes override graphics behavior in the renumber tool by:

• Adding AreaPlan and ThreeD view types to get_open_views() to fix issue #2951
• Changing marking to affect all open views instead of just the active view
• Storing and restoring original element override states instead of resetting to defaults
• Refactoring renumbered_element_ids from list to dict structure to track per-element, per-view overrides

Review Summary:

Found one critical bug in the door_by_room_renumber() function where the refactoring was incomplete - the data structure was changed from list to dict but the code still uses .append() which will cause a runtime crash. The main pick_and_renumber() logic is sound and correctly captures override states before marking. Also identified a performance optimization opportunity to reduce redundant API calls.

The core fix addresses the reported issue where elements remained visually marked in Area Plan views because those view types weren't included in the unmark operation.

Follow-up suggestions:

• @devloai fix the identified issues - Address the critical bug in door_by_room_renumber and the performance optimization

[Copilot]

Pull request overview

This PR enhances the ReNumber tool's override graphics behavior by adding support for Area Plan and 3D views, applying visual marking across all open views (consistent with the unmark behavior), and preserving custom per-element override settings during the renumber/unmark cycle.

Key Changes

• Extended view type support to include AreaPlan and ThreeD views
• Modified marking behavior to apply across all open views instead of just the active view
• Implemented override state preservation by storing original overrides before marking and restoring them during unmark

[Wurschdhaud]

fixed:

• rename var room to element
• mark and unmark accept view as var to avoid calling function multiple times
• fix missing door implementation for dic instead of list
• black format

additionally:
use class instead of enum for script entry and view validation. Intention as described in #2951 (comment) should be kept that way and be consistent.

@jmcouffin tested, rerun copilot to verify

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.

[Wurschdhaud]

I changed the warning to a progressbar to show the current number. I know that should be a separate PR, since it's no fix but a new feature, but it's a two liner, hope that's ok.
Easier to debug when the count that's happening in the background is actually visible.

[jmcouffin]

I changed the warning to a progressbar to show the current number. I know that should be a separate PR, since it's no fix but a new feature, but it's a two liner, hope that's ok. Easier to debug when the count that's happening in the background is actually visible.

Great and no worry. If it is not messy, it not an oss nor pyrevit 🤣