fix: accept and discard extra kwargs in Signal.fire for back compat

Author: bluetoothbot

src/zeroconf/_services/__init__.py

@@ -24,7 +24,7 @@
 
 import enum
 from collections.abc import Callable
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Any
 
 if TYPE_CHECKING:
     from .._core import Zeroconf
@@ -61,6 +61,7 @@ def fire(
         service_type: str,
         name: str,
         state_change: ServiceStateChange,
+        **kwargs: Any,
     ) -> None:
         for h in self._handlers[:]:
             h(

tests/test_services.py

@@ -303,19 +303,28 @@ def handler(
     ]
 
 
-def test_signal_fire_rejects_unknown_kwarg():
-    """Signal.fire rejects keyword args outside the contract."""
+def test_signal_fire_discards_unknown_kwarg():
+    """Signal.fire accepts extra keyword args and does not forward them."""
     signal = r.Signal()
-    signal.registration_interface.register_handler(lambda **_: None)
+    captured: list[dict[str, Any]] = []
+    signal.registration_interface.register_handler(lambda **kw: captured.append(kw))
 
-    with pytest.raises(TypeError, match="unexpected keyword argument"):
-        signal.fire(
-            zeroconf=None,  # type: ignore[arg-type]
-            service_type="_http._tcp.local.",
-            name="x._http._tcp.local.",
-            state_change=r.ServiceStateChange.Added,
-            bogus=1,  # type: ignore[call-arg]
-        )
+    signal.fire(
+        zeroconf=None,  # type: ignore[arg-type]
+        service_type="_http._tcp.local.",
+        name="x._http._tcp.local.",
+        state_change=r.ServiceStateChange.Added,
+        bogus=1,
+    )
+
+    assert captured == [
+        {
+            "zeroconf": None,
+            "service_type": "_http._tcp.local.",
+            "name": "x._http._tcp.local.",
+            "state_change": r.ServiceStateChange.Added,
+        }
+    ]
 
 
 def test_signal_fire_rejects_positional_args():