Skip to content

Commit 12fbc90

Browse files
authored
gh-158592: Reallocate the list's array when deleting by index (gh-158602)
1 parent b51d4b3 commit 12fbc90

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
``del list[index]`` now triggers shrinking the list's internal array.

‎Objects/listobject.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1182,7 +1182,7 @@ list_ass_item_lock_held(PyListObject *a, Py_ssize_t i, PyObject *v)
11821182
if (i < size - 1) {
11831183
list_shift_items_left_lock_held(a, i, size - 1);
11841184
}
1185-
Py_SET_SIZE(a, size - 1);
1185+
list_resize(a, size - 1); // NB: shrinking a list can't fail
11861186
}
11871187
else {
11881188
FT_ATOMIC_STORE_PTR_RELEASE(a->ob_item[i], Py_NewRef(v));

0 commit comments

Comments
 (0)