update tests

Author: brijkapadia

Lib/test/test_capi/test_function.py

@@ -325,28 +325,6 @@ def annofn(arg: int) -> str:
         with self.assertRaises(SystemError):
             _testcapi.function_get_annotations(None)
 
-    def test_function_old_codes(self):
-        def f():
-            pass
-
-        def g():
-            pass
-
-        def h():
-            pass
-
-        old_codes = _testcapi.function_get_old_codes(f)
-        self.assertIsNone(old_codes)
-
-        f.__code__ = g.__code__
-        old_codes = _testcapi.function_get_old_codes(f)
-        self.assertIsInstance(old_codes, list)
-        self.assertEqual(len(old_codes), 1)
-
-        f.__code__ = h.__code__
-        old_codes = _testcapi.function_get_old_codes(f)
-        self.assertEqual(len(old_codes), 2)
-
     # TODO: test PyFunction_New()
     # TODO: test PyFunction_NewWithQualName()
     # TODO: test PyFunction_SetVectorcall()

Lib/test/test_ctypes/test_functions.py

@@ -463,6 +463,35 @@ def callback(*args):
         callback = proto(callback)
         self.assertRaises(ArgumentError, lambda: callback((1, 2, 3, 4), POINT()))
 
+    def test_reassign_code_while_running(self):
+        freevar1 = None
+        freevar2 = None
+
+        def replacement():
+            freevar1
+            freevar2
+            return "replacement"
+
+        def original():
+            original.__code__ = replacement.__code__
+            return "original"
+
+        self.assertEqual(original(), "original")
+        self.assertEqual(original(), "replacement")
+
+    def test_function_code_object_memory_leak(self):
+        def get_function(i):
+            ns = {}
+            exec(f"def f(): return {i}", ns)
+            return ns["f"]
+
+        def f(): pass
+
+        for i in range(1000):
+            f.__code__ = get_function(i).__code__
+
+        self.assertEqual(f(), 999)
+
 
 if __name__ == '__main__':
     unittest.main()

Modules/_testcapi/function.c

@@ -130,19 +130,6 @@ function_get_annotations(PyObject *self, PyObject *func)
 }
 
 
-static PyObject *
-function_get_old_codes(PyObject *self, PyObject *func)
-{
-    PyFunctionObject *func_o = (PyFunctionObject *) func;
-    PyObject *old_codes = func_o->func_old_codes;
-    if (old_codes == NULL) {
-        Py_RETURN_NONE;
-    }
-
-    return Py_NewRef(old_codes);
-}
-
-
 static PyMethodDef test_methods[] = {
     {"function_get_code", function_get_code, METH_O, NULL},
     {"function_get_globals", function_get_globals, METH_O, NULL},
@@ -154,7 +141,6 @@ static PyMethodDef test_methods[] = {
     {"function_get_closure", function_get_closure, METH_O, NULL},
     {"function_set_closure", function_set_closure, METH_VARARGS, NULL},
     {"function_get_annotations", function_get_annotations, METH_O, NULL},
-    {"function_get_old_codes", function_get_old_codes, METH_O, NULL},
     {NULL},
 };