Skip to content

Commit 8f7988d

Browse files
committed
Address comments. Variety of small nits and cleanups.
1 parent d41581f commit 8f7988d

6 files changed

Lines changed: 8 additions & 7 deletions

File tree

.github/CODEOWNERS

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -290,9 +290,10 @@ Tools/jit/ @brandtbucher @savannahostrowski @diegorusso
290290
InternalDocs/jit.md @brandtbucher @savannahostrowski @diegorusso @AA-Turner
291291

292292
# Lazy imports (PEP 810)
293-
Objects/lazyimportobject.c @yhg1s @DinoV @pablogsal
294-
Include/internal/pycore_lazyimportobject.h @yhg1s @DinoV @pablogsal
295-
Lib/test/test_lazy_import @yhg1s @DinoV @pablogsal
293+
.github/workflows/reusable-test-lazy-imports-all.yml @yhg1s @DinoV @pablogsal @brittanyrey
294+
Objects/lazyimportobject.c @yhg1s @DinoV @pablogsal
295+
Include/internal/pycore_lazyimportobject.h @yhg1s @DinoV @pablogsal
296+
Lib/test/test_lazy_import @yhg1s @DinoV @pablogsal
296297

297298
# Micro-op / μop / Tier 2 Optimiser
298299
Python/optimizer.c @markshannon @Fidget-Spinner

.github/workflows/build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -712,4 +712,5 @@ jobs:
712712
${{ !fromJSON(needs.build-context.outputs.run-ios) && 'build-ios,' || '' }}
713713
${{ !fromJSON(needs.build-context.outputs.run-emscripten) && 'build-emscripten,' || '' }}
714714
${{ !fromJSON(needs.build-context.outputs.run-wasi) && 'build-wasi,' || '' }}
715+
${{ !fromJSON(needs.build-context.outputs.run-tests) && 'test-lazy-imports-all,' || '' }}
715716
jobs: ${{ toJSON(needs) }}

.github/workflows/reusable-test-lazy-imports-all.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
env:
2727
EXCLUDE_FILE: Lib/test/lazy_imports_all_exclude.txt
2828
steps:
29-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
29+
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
3030
with:
3131
persist-credentials: false
3232
- name: Register gcc problem matcher
@@ -47,7 +47,7 @@ jobs:
4747
./python -m test --list-tests > all_tests.txt
4848
# Strip comments/blank lines from the exclusion file, then drop those
4949
# exact test names (whole-line, fixed-string match) from the run list.
50-
grep -vE '^\s*(#.*)?$' "$EXCLUDE_FILE" > exclude_tests.txt
50+
grep -vE '^\s*(#.*)?$' "$EXCLUDE_FILE" > exclude_tests.txt || true
5151
grep -vxF -f exclude_tests.txt all_tests.txt > run_tests.txt
5252
# Fail loudly if any exclusion entry matched nothing: a stale or
5353
# mistyped name (or a change in `--list-tests` output) would otherwise
@@ -60,9 +60,8 @@ jobs:
6060
fi
6161
echo "Excluding $(wc -l < exclude_tests.txt) module(s); running $(wc -l < run_tests.txt) of $(wc -l < all_tests.txt)."
6262
- name: Run tests with lazy imports
63-
run: xvfb-run xargs ./python -X lazy_imports=all -m test --fast-ci --timeout=900 < run_tests.txt
63+
run: xvfb-run xargs -a run_tests.txt ./python -X lazy_imports=all -m test --fast-ci --timeout=900 < /dev/null
6464
- name: Verify excluded tests still need exclusion
65-
if: success()
6665
run: |
6766
set -euo pipefail
6867
unexpected_passes=()

4

Whitespace-only changes.

q

Whitespace-only changes.

w

Whitespace-only changes.

0 commit comments

Comments
 (0)