Exercise critical section generation in testclinic

Author: cmaloney

Modules/_testclinic.c

@@ -2350,11 +2350,14 @@ static PyTypeObject VcNew_Type = {
 };
 
 
-/* VcInit: __init__ with one required positional-only and one optional keyword arg */
+/* VcInit: __init__ with one required positional-only and one optional keyword
+ * arg.  Uses @critical_section to exercise the {lock}/impl/{unlock} placement
+ * in both the helper body and the vectorcall fast-path inner block. */
 
 /*[clinic input]
 class _testclinic.VcInit "PyObject *" "&VcInit_Type"
 @vectorcall
+@critical_section
 _testclinic.VcInit.__init__ as vc_posorkw_init
     a: object
     /
@@ -2363,7 +2366,7 @@ _testclinic.VcInit.__init__ as vc_posorkw_init
 
 static int
 vc_posorkw_init_impl(PyObject *self, PyObject *a, PyObject *b)
-/*[clinic end generated code: output=6018424ba9fb0744 input=25e4c2b792040c31]*/
+/*[clinic end generated code: output=6018424ba9fb0744 input=7a4513f78dd42b57]*/
 {
     return 0;
 }

Modules/clinic/_testclinic.c.h

@@ -1227,14 +1227,15 @@ def _vc_finale(self) -> str:
         if self.func.kind is METHOD_INIT:
             return libclinic.normalize_snippet("""
                 {modifications}
-                {lock}
                 {{
                     PyObject *self = _PyType_CAST(type)->tp_alloc(
                         _PyType_CAST(type), 0);
                     if (self == NULL) {{
                         goto exit;
                     }}
-                    int _result = {c_basename}_impl({vc_impl_arguments});
+                    int _result;
+                    {lock}
+                    _result = {c_basename}_impl({vc_impl_arguments});
                     {unlock}
                     if (_result != 0) {{
                         Py_DECREF(self);